Summary: imm: fix memory leak in PBE [#2260] Review request for Trac Ticket(s): 2260 Peer Reviewer(s): Neelakanta, Hung Pull request to: Zoran Affected branch(es): opensaf-5.0.x, opensaf-5.1.x, default(5.2) Development branch: default(5.2)
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 3e89f5ba272d17a302554ee632cb24cce0bea923 Author: Zoran Milinkovic <[email protected]> Date: Thu, 12 Jan 2017 14:19:28 +0100 imm: fix memory leak in PBE [#2260] Fix memory leak in PBE when admin op for resource display is invoked. Additional indentation fix is added to the patch. Complete diffstat: ------------------ src/imm/immpbed/immpbe_daemon.cc | 34 ++++++++++++++++++---------------- 1 files changed, 18 insertions(+), 16 deletions(-) Testing Commands: ----------------- immadm -O displayverbose -p resource:SA_STRING_T:implementers opensafImm=opensafImm,safApp=safImmService Testing, Expected Results: -------------------------- Run OpenSAF with PBE running with valgrind. Execute the testing command No memory leak should be reported by valgrind Conditions of Submission: ------------------------- Ack from Hung and Neelakanta Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
