Summary: amf: change saAmfCompCmdEnv attribute to writable [#2255] V2 Review request for Trac Ticket(s): #2255 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Current OpenSAF implementation defines the attribute saAmfCompCmdEnv in the SaAmfComp object as non-writable according to last AMF specification. This restriction doesn't allow to upgrade environment attributes defined at component instance and, to remove it, the attribute was made writable in an errata to the model. OpenSAF should comply to this definition in the errata (www.saforum.org/HOA/assn16627/images/SAI-IM-XMI-A.04.02.errata.xml.zip) of the AMF specification to enable the upgrade of environment attributes defined at component instance level. changeset 2e379a89603e3404b754737e73becd381da90278 Author: Nguyen TK Luu <[email protected]> Date: Mon, 23 Jan 2017 10:05:58 +0700 amf: change saAmfCompCmdEnv attribute to writable [#2255] Complete diffstat: ------------------ src/amf/amfd/comp.cc | 15 +++++++++++++++ src/amf/amfnd/compdb.cc | 2 ++ src/amf/common/amf_defs.h | 2 ++ src/amf/config/amf_classes.xml | 1 + 4 files changed, 20 insertions(+), 0 deletions(-) Testing Commands: ----------------- Change saAmfCompCmdEnv with immcfg Testing, Expected Results: -------------------------- saAmfCompCmdEnv is successfully changed Conditions of Submission: ------------------------- ACK from reviewers or after 2 weeks Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
