Summary: amfd: remove limitation on IMM job queue size on standby controller [#2252] Review request for Trac Ticket(s): #2252 Peer Reviewer(s): AMF devs Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset d70fc5ef40dc5da1a9014eeb04e0f41d82363b47 Author: Praveen Malviya <[email protected]> Date: Mon, 30 Jan 2017 17:18:46 +0530 amfd: remove limitation on IMM job queue size on standby controller [#2252] Standby AMFD keeps 500 jobs related to IMM updates in its queue. Whenever this size limit increases, job queue is trimmed to 250. Patch removes this limitation. Now active AMFD will ask standby AMFD through MBCSv checkpointing to flush its job queue when a) active AMFD finishes all IMM runtime updates and its job queue becomes empty and b) when COLD sync state of standy changes from OUT_OF_SYNC to IN_SYNC when standby joins cluster first time. Complete diffstat: ------------------ src/amf/amfd/chkop.cc | 8 +++++++- src/amf/amfd/ckpt.h | 3 ++- src/amf/amfd/ckpt_dec.cc | 15 ++++++++++++++- src/amf/amfd/ckpt_enc.cc | 13 ++++++++++++- src/amf/amfd/ckpt_msg.h | 1 + src/amf/amfd/imm.cc | 31 ++++++++++--------------------- src/amf/amfd/imm.h | 1 + src/amf/amfd/main.cc | 10 +++++++++- 8 files changed, 56 insertions(+), 26 deletions(-) Testing Commands: ----------------- 1)Tested new amfd and new amfd combination. 2)Tested new amfd and old amfd combination. 3)Brought up AMF demo. Testing, Expected Results: -------------------------- In new amfd and old amfd combination active amfd does not checkpoints job queue size. In all other cases, active amfd checkpoints job queue status when its size becomes zero. Upon receiving this ckpt update, standby empties its job queue. Conditions of Submission: ------------------------- Ack from any reveiwer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
