Summary:logd: implement cfg files rotation [#2239] Review request for Trac Ticket(s): #2239 Peer Reviewer(s): Vu, Lennart, Canh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 9eaf276ed3fa99a0e69f67919c9217cf5ef5bdc0 Author: A V Mahesh <[email protected]> Date: Mon, 06 Feb 2017 12:01:37 +0530 logd: implement cfg files rotation [#2239] Requirement : Current implementation of LOGsv do rotation of log files as defined, but not for cfg files. So, if we play with log streams application in a long time a large numbers of cfg files are generated , which is causing system space issue. Implementation : SAI-AIS-LOG-A.02.01 specification not defied the approach on .cfg ROTATE policy, so it is implementation specific , this enhancement taken approach as CFG file can also be ROTATED concurrently whenever the log files with the same <closetime> suffix is being ROTATED. This enhancement ensures Until the old log files is not deleted and the old .cfg file is still available since it contains information about how to read the old log files, in other words when the last old log file has been rotated out also the old .cfg file will be removed (but not before that). Notes : README will be update if LOG developers thinks it is required Complete diffstat: ------------------ src/log/logd/lgs_file.cc | 4 +++ src/log/logd/lgs_file.h | 1 + src/log/logd/lgs_filehdl.cc | 182 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----- src/log/logd/lgs_filehdl.h | 2 + src/log/logd/lgs_stream.cc | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------ 5 files changed, 262 insertions(+), 15 deletions(-) Testing Commands: ----------------- Similar to Log rotation test Testing, Expected Results: -------------------------- Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
