Dear Zoran,
I am sorry if you are waiting for me in this ticket. ACK. Sincerely, Hoang -----Original Message----- From: Zoran Milinkovic [mailto:[email protected]] Sent: Wednesday, February 1, 2017 8:13 PM To: A V Mahesh <[email protected]> Cc: [email protected] Subject: Re: [devel] [PATCH 1 of 1] ckpt: return SA_AIS_ERR_BAD_HANDLE if ckpt handle is not found in checkpoint open call [#2283] Hi Mahesh, I was going through the code and found that the function does not reply back to the agent if client node is not found. Since the API call is synchronized, if the agent does not get the reply back from ND, the call will wait until it reaches the timeout. If you look at the code, you will see that it's obvious that this reply is missing in the function. BR, Zoran -----Original Message----- From: A V Mahesh [mailto:[email protected]] Sent: den 1 februari 2017 04:39 To: Zoran Milinkovic <[email protected]> Cc: [email protected] Subject: Re: [PATCH 1 of 1] ckpt: return SA_AIS_ERR_BAD_HANDLE if ckpt handle is not found in checkpoint open call [#2283] Hi Zoran, ACK , not tested. Is this case getting hit in case of Headless ? -AVM On 1/31/2017 6:24 PM, Zoran Milinkovic wrote: > src/ckpt/ckptnd/cpnd_evt.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > > If a client node is not found in cpnd_evt_proc_ckpt_open(), the checkpoint node director will reply with SA_AIS_ERR_BAD_HANDLE. > > diff --git a/src/ckpt/ckptnd/cpnd_evt.c b/src/ckpt/ckptnd/cpnd_evt.c > --- a/src/ckpt/ckptnd/cpnd_evt.c > +++ b/src/ckpt/ckptnd/cpnd_evt.c > @@ -616,7 +616,8 @@ static uint32_t cpnd_evt_proc_ckpt_open( > cpnd_client_node_get(cb, client_hdl, &cl_node); > if (cl_node == NULL) { > TRACE_4("cpnd client hdl get failed for client hdl:%llx",client_hdl); > - return rc; > + send_evt.info.cpa.info.openRsp.error = SA_AIS_ERR_BAD_HANDLE; > + goto agent_rsp; > } > > if (((cp_node = cpnd_ckpt_node_find_by_name(cb, ckpt_name)) != > NULL) && cp_node->is_unlink == false) { ---------------------------------------------------------------------------- -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
