Summary: base: Add methods for reading the FQDN, host name and node name [#2267] Review request for Trac Ticket(s): 2267 Peer Reviewer(s): Ramesh(base), Mahesh(mds) Pull request to: Affected branch(es): default(5.2) Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset e874de09038cf50c44c7ea5a7c9b59d04de5e286 Author: Anders Widell <[email protected]> Date: Fri, 17 Feb 2017 10:23:45 +0100 base: Add methods for reading the FQDN, host name and node name [#2267] Add a new class called Conf the contains methods for reading the fully qualified domain name, the short host name and the configured OpenSAF node name. changeset 028665496771975d8ac613fda3a89c128707c02f Author: Anders Widell <[email protected]> Date: Fri, 17 Feb 2017 10:23:50 +0100 mds: Use the new base class Conf for reading the FQDN [#2267] The HOSTNAME field of the log messages should contain the FQDN of the originator. Use the newly introduced Conf class in the base component to read the FQDN. Complete diffstat: ------------------ src/base/Makefile.am | 2 ++ src/base/conf.cc | 152 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/base/conf.h | 106 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/mds/mds_log.cc | 39 ++++++++++++++++++--------------------- 4 files changed, 278 insertions(+), 21 deletions(-) Testing Commands: ----------------- Start OpenSAF and read the MDS log. Testing, Expected Results: -------------------------- The FQDN of the host should be logged in the MDS log. Conditions of Submission: ------------------------- Ack from reviewer(s) Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
