Summary: osaf: fix saflog to handle long log record [#2313]
Review request for Trac Ticket(s): #2313
Peer Reviewer(s): Lennart Lund, Mahesh Valla, Vu M Nguyen
Pull request to: Vu M Nguyen
Affected branch(es): all
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
saflog is a utility function provided for other OpenSAF services
to write log records to the system log stream.
Before this ticket, saflog limited the log record size to only 255
chars, which made it not possible to write log records containing
long dns (> 255 chars).
This ticket increases the log record size limit to 65,535 chars
(SA_LOG_MAX_RECORD_SIZE) to allow logging long log records that
may contain long dns.
changeset 5a45816a6858f098ec6ba10fcc365585fa69b6fb
Author: Nguyen TK Luu <nguyen.tk....@dektech.com.au>
Date: Wed, 22 Feb 2017 10:30:59 +0700
osaf: fix saflog to handle long log record [#2313]
saflog is a utility function provided for other OpenSAF services to
write
log records to the system log stream.
Before this ticket, saflog limited the log record size to only 255
chars,
which made it not possible to write log records containing long dns (>
255
chars).
This ticket increases the log record size limit to 65,535 chars
(SA_LOG_MAX_RECORD_SIZE) to allow logging long log records that may
contain
long dns.
Complete diffstat:
------------------
src/osaf/saflog/saflog.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
Testing Commands:
-----------------
Use amf_demo with 2N model containing long dns.
Do some admin ops on the SU/Comp of amf_demo.
Testing, Expected Results:
--------------------------
Created long-dn objects and changed states of SU/Comp
after admin ops are logged to saLogSystem_xxx file.
Conditions of Submission:
-------------------------
Ack from reviewers or after 2 weeks
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
