Summary: log: add alternative destinations of log records [#2258]
Review request for Trac Ticket(s): #2258
Peer Reviewer(s): Lennart, Canh, Mahesh
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): Default
Development branch: Default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
These patches have dependent on following patches
which are in review status, but not pushed yet.
1) #2293 sent by Anders (which has updated on base::UnixClientSocket class)
2) #2266 sent by Anders (which provide base::Hash function)
3) #2258 sent by Lennart (which implement configuration handler)
changeset 8db71d01210b384f65af209e0f7711e27ff6f553
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Thu, 23 Feb 2017 14:37:32 +0700
log: add alternative destinations of log records [#2258]
Here are major info, detailed info will be added to PR doc soon. 1) Add
attribute "saLogRecordDestination" to log stream. 2) Add Local socket
destintion handler 3) Add NILDEST destination type 4) Integrate into
first
increment made by Lennart
changeset 57b284cdfd5cd07812452d263fadd522a0db35af
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Wed, 15 Feb 2017 15:07:09 +0700
log: add UML test case to verify alternative destination [#2258]
Major changes: 1) Modify Lennart's test cases because enhancing
destination
configuration validation rules. 2) Add test suite #18 to verify
alternative
destination
Added Files:
------------
src/log/apitest/tet_cfg_destination.c
src/log/logd/lgs_common.h
src/log/logd/lgs_dest.cc
src/log/logd/lgs_dest.h
src/log/logd/lgs_mbcsv_v7.cc
src/log/logd/lgs_mbcsv_v7.h
src/log/logd/lgs_nildest.cc
src/log/logd/lgs_nildest.h
src/log/logd/lgs_unixsock_dest.cc
src/log/logd/lgs_unixsock_dest.h
Complete diffstat:
------------------
src/log/Makefile.am | 18 ++++-
src/log/apitest/tet_LogOiOps.c | 10 +-
src/log/apitest/tet_cfg_destination.c | 509
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/log/config/logsv_classes.xml | 7 +-
src/log/logd/lgs_common.h | 81 ++++++++++++++++++++++
src/log/logd/lgs_config.cc | 173
++++++++++++++++++++++++++++++++++++++++++-----
src/log/logd/lgs_config.h | 3 +-
src/log/logd/lgs_dest.cc | 409
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/log/logd/lgs_dest.h | 294
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/log/logd/lgs_evt.cc | 32 ++++++++
src/log/logd/lgs_imm.cc | 211
+++++++++++++++++++++++++++++++++++++++++++++++++---------
src/log/logd/lgs_main.cc | 11 ++-
src/log/logd/lgs_mbcsv.cc | 229
++++++++++++++++++++++++++++++++++++++++++++++++++------------
src/log/logd/lgs_mbcsv.h | 5 +-
src/log/logd/lgs_mbcsv_v5.cc | 10 ++
src/log/logd/lgs_mbcsv_v7.cc | 177
+++++++++++++++++++++++++++++++++++++++++++++++++
src/log/logd/lgs_mbcsv_v7.h | 65 ++++++++++++++++++
src/log/logd/lgs_nildest.cc | 153
++++++++++++++++++++++++++++++++++++++++++
src/log/logd/lgs_nildest.h | 72 +++++++++++++++++++
src/log/logd/lgs_stream.cc | 62 ++++++++++++++++-
src/log/logd/lgs_stream.h | 16 ++++
src/log/logd/lgs_unixsock_dest.cc | 343
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/log/logd/lgs_unixsock_dest.h | 245
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/log/logd/lgs_util.cc | 34 +++++++++
src/log/logd/lgs_util.h | 11 ++-
25 files changed, 3065 insertions(+), 115 deletions(-)
Testing Commands:
-----------------
Run test suite #18 or all logtest
Testing, Expected Results:
--------------------------
All test PASSED
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
