Summary: amfd: Do not adjust saAmfSUAdminState [#2210] Review request for Trac Ticket(s): 2210 Peer Reviewer(s): AMF maintainers Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 4a390d5aa49a1296cd43b939fe08e6384e14ce0b Author: Minh Hon Chau <[email protected]> Date: Fri, 24 Feb 2017 11:26:06 +1100 amfd: Do not adjust saAmfSUAdminState [#2210] If loss of update saAmfSUAdminState before headless occurs, amfd currently does not have enough information to adjust saAmfSUAdminState. The reason is that amfd can not differentiate whether si-swap or su-lock has been executed before headless if saAmfSUAdminState was lost to update in IMM. Both si-swap and su-lock are using the same SG FSM STATE, having QUIESCED assignment. This patch prioritizes si-swap and ignore to update saAmfSUAdminState to LOCKED in order to avoid out of service. Complete diffstat: ------------------ src/amf/amfd/siass.cc | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) Testing Commands: ----------------- Steps - Set up 2N application - issue si-swap, delay QUIESCED csi set callback - Stop both SCs - Restart one SC Observation: SU has QUIESCED assignment becoming LOCKED Testing, Expected Results: -------------------------- Repeat the above steps si-swap can continue, no SU is LOCKED Conditions of Submission: ------------------------- ack from reviewer Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
