ack, code review only. /Thanks HansN

On 03/02/2017 03:47 AM, Tai Dinh wrote:
>   src/amf/amfd/nodegroup.cc |  4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
>
> During instantiation of node group, AMF does not check for the admin state of
> the SG of SUs lead to the result that SUs will be instantiated even if their
> SG is at LOCKED_INSTANTIATION state.
>
> diff --git a/src/amf/amfd/nodegroup.cc b/src/amf/amfd/nodegroup.cc
> --- a/src/amf/amfd/nodegroup.cc
> +++ b/src/amf/amfd/nodegroup.cc
> @@ -1011,6 +1011,10 @@ static void ng_admin_unlock_inst(AVD_AMF
>                          Also honor saAmfSURank while instantating.
>                        */
>                       AVD_SG *sg = node_su->sg_of_su;
> +                     if (sg->saAmfSGAdminState == 
> SA_AMF_ADMIN_LOCKED_INSTANTIATION) {
> +                             TRACE("SG of '%s' SU is in locked-in, skip it", 
> node_su->name.c_str());
> +                             continue;
> +                     }
>   
>                       std::set<std::string>::const_iterator iter1 ;
>                       iter1 = tmp_sg_list.find(sg->name);


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to