Summary: amfnd: update counters during switchover [#2345] Review request for Trac Ticket(s): #2345 Peer Reviewer(s): Amf Dev Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 5.1 and default Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 3268649ae0f11819489da0d3ba7258f30773ccef Author: Nagendra Kumar<[email protected]> Date: Mon, 06 Mar 2017 13:15:11 +0530 amfnd: update counters during switchover [#2345] In some cases, Amfnd is getting role change event before AVD up message, which is rare. In avnd_evt_avd_role_change_evh, if AVD flag is not marked up, then it is not updating the counters and returning from there. This creates a mismatch into counters of messages exchanged among amfd and amfnd. This leads to Amfnd reboots the node. Since, avnd_evt_avd_role_change_evh is not a significant message for Amfnd, so we can update the messages counters first and return from there. Complete diffstat: ------------------ src/amf/amfnd/di.cc | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) Testing Commands: ----------------- As per ticket. Testing, Expected Results: -------------------------- No crash of Amfnd. Conditions of Submission: ------------------------- Ack Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
