Summary: amfd: handle TIMEOUT for avd_imm_applier_set [#2338] Review request for Trac Ticket(s): #2338 Peer Reviewer(s): Amf Dev Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset b461f589dfcde95911f0b04881c5e518278f2b55 Author: Nagendra Kumar<[email protected]> Date: Wed, 08 Mar 2017 13:12:19 +0530 amfd: handle TIMEOUT for avd_imm_applier_set [#2338] Complete diffstat: ------------------ src/amf/amfd/role.cc | 22 ++++++++++++++++------ src/amf/amfd/role.h | 2 +- 2 files changed, 17 insertions(+), 7 deletions(-) Testing Commands: ----------------- 1. To reproduce it, do the following changesi at SC-1: diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc --- a/src/amf/amfd/imm.cc +++ b/src/amf/amfd/imm.cc @@ -1495,6 +1495,9 @@ SaAisErrorT avd_imm_applier_set(void) LOG_ER("Impl Set Failed for %s, returned %d", avd_class_names[i], rc); break; } + LOG_ER("1. Impl Set for %s ========================", avd_class_names[i]); + sleep (1); + LOG_ER("2. Impl Set for %s ========================", avd_class_names[i]); 2. Start SC-1 as Act and SC-2 as Standby. Now perform si swap of controllers and when logs of "Impl Set Failed for" starts comming on Quisced node(SC-1), kill immd on new Act node(SC-2). SC-2 will reboot. 3. Amfd (SC-1) will hang in avd_imm_applier_set for 10 sec and timeout. Testing, Expected Results: -------------------------- After step 3, Amfd on SC-1 is declaring itself Act and when SC-2 comes up after reboot, then it joins as Standby. Conditions of Submission: ------------------------- Ack Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition. http://sdm.link/oxford _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
