Summary: log: fix both active and standby side own the same log file name [#2383] Review request for Trac Ticket(s): #2383 Peer Reviewer(s): Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): all branches Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset f0480d40a0a89b3523dd4dcbc45c91e47a335da4 Author: Canh Van Truong <[email protected]> Date: Thu, 16 Mar 2017 14:55:09 +0100 log: fix both active and standby sites own the same log file name [#2383] The issues: It's happen because when switchover, active side switch to quiesced. For short period (MDS's quiesced acknowledgment time), the log server in quiesced state may still get request from log agent if these request already put to mds queue. if the request are open stream or write async, the log file is opened and is not closed in switchover processing any more when it up to standby. An other side that switch from standby to active state may also open the same log file name. This cause when delete cfg app stream, closing, rename log file will happen in both active and standby. And just rename in active side is successfull, in standby will be failed Fix: When the lgs has HA state up to quiesced and receive mds callback with MDS_CALLBACK_QUIESCED_ACK, lgs check all stream, if any stream are opening log file, closing all log file. There are also converting LOG_ER to LOG_WA if renaming log file and get error return from file handle thread. Complete diffstat: ------------------ src/log/logd/lgs_amf.cc | 4 +--- src/log/logd/lgs_evt.cc | 9 +++++++++ src/log/logd/lgs_stream.cc | 4 ++-- 3 files changed, 12 insertions(+), 5 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- Ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
