Summary: ckpt: Add option OSAF_CKPT_SHM_ALLOC_GUARANTEE=2 for backwards
compatibility [#2395]
Review request for Trac Ticket(s): 2395
Peer Reviewer(s): Mahesh
Pull request to:
Affected branch(es): default(5.2)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 940295ebc4b1d4b67616fe6e80ee09b74c4ddcad
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 06 Apr 2017 13:14:01 +0200
ckpt: Add option OSAF_CKPT_SHM_ALLOC_GUARANTEE=2 for backwards
compatibility
[#2395]
The setting OSAF_CKPT_SHM_ALLOC_GUARANTEE=0 results in increased memory
usage, whereas the setting OSAF_CKPT_SHM_ALLOC_GUARANTEE=1 results in
lower
performance. Thus, there was no way to configure CKPT to avoid a
characteristics regression.
Fix this by adding a third option: OSAF_CKPT_SHM_ALLOC_GUARANTEE=2. This
setting will be the default, and result in no degradation of
performance or
memory usage.
Complete diffstat:
------------------
src/ckpt/ckptnd/ckptnd.conf | 6 ++++++
src/ckpt/ckptnd/cpnd_cb.h | 3 ++-
src/ckpt/ckptnd/cpnd_init.c | 3 ++-
src/ckpt/ckptnd/cpnd_proc.c | 9 +++++----
src/ckpt/ckptnd/cpnd_res.c | 9 +++++----
5 files changed, 20 insertions(+), 10 deletions(-)
Testing Commands:
-----------------
Run characteristics measurements of CKPT.
Testing, Expected Results:
--------------------------
No significant increase in memory usage or decrease of performance compared to
OpenSAF 5.1.0.
Conditions of Submission:
-------------------------
Ack from reviwer(s)
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
