Hi Alex,
Reviewed and tested the patch.
The patch avoids, the crash in smfd.
I have the following Questions on the implementation(which was
overlooked at the time of #2145 review):
1. If the component is killed when the campaign is in
SA_SMF_CMPG_EXECUTION_COMPLETED state(as in the defect) and
the amfnd does not re-start the component because,
saAmfSUMaintenanceCampaign is set. The saSmfCmpgError indication is not
given in SMF, because the campaign is in the process of committing.
who does this justify Asynchronous Failures of AMF Entities?
2.
according to SMF AIS, the async failures has to be considered Executing,
Suspending, or RollingBack only.
Then how do we prevent in other states? And the AMFND still will not
re-start(correct) because of saAmfSUMaintenanceCampaign is set.
Thanks,
Neel.
On 2017/04/06 11:56 PM, Alex Jones wrote:
> src/smf/smfd/SmfCampaignThread.cc | 16 ++++++++++------
> 1 files changed, 10 insertions(+), 6 deletions(-)
>
>
> smfd core dumps during commit of campaign.
>
> If an AMF SU under maintenance fails right as the campaign commit is done,
> there
> is a race condition present. Before SMF clears the suMaintenaceCampaign
> attribute of the SU, if the SU fails, it will send a notification. Meanwhile,
> the commit deletes upgrade campaign pointer inside smfd. If the deletion of
> the
> campaign pointer inside smfd occurs before it receives the NTF event a crash
> will occur because the campaign pointer is gone.
>
> Solution is to always process NTF events before processing the termination of
> the campaign. The campaign termination code sets "m_running" to false, and
> deletes the pointer. This should always be last in the poll loop so that the
> loop will exit immediately without processing any NTF events (or other future
> events.)
>
> diff --git a/src/smf/smfd/SmfCampaignThread.cc
> b/src/smf/smfd/SmfCampaignThread.cc
> --- a/src/smf/smfd/SmfCampaignThread.cc
> +++ b/src/smf/smfd/SmfCampaignThread.cc
> @@ -907,12 +907,10 @@ int SmfCampaignThread::handleEvents(void
> break;
> }
>
> - /* Process the Mail box events */
> - if (fds[0].revents & POLLIN) {
> - /* dispatch MBX events */
> - processEvt();
> - }
> -
> + /*
> + * Handle NTF events first because processEvt may delete and terminate
> the
> + * campaign thread.
> + */
> if (fds[1].revents & POLLIN) {
> // dispatch NTF events
> rc = saNtfDispatch(m_ntfHandle, SA_DISPATCH_ALL);
> @@ -922,6 +920,12 @@ int SmfCampaignThread::handleEvents(void
> }
> }
>
> + /* Process the Mail box events */
> + if (fds[0].revents & POLLIN) {
> + /* dispatch MBX events */
> + processEvt();
> + }
> +
> m_campaign->updateElapsedTime();
> }
> TRACE_LEAVE();
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
