Ack, code review only.
Thanks,
praveen
On 12-Apr-17 6:06 PM, Nguyen Luu wrote:
> The $piddir variable (containing path to amf_demo comp's pid file)
> is missed to be defined in amf_demo_script.
>
> This could lead to the amf_demo process not getting truely killed
> in some cases when cleanup is called (e.g when invoking
> saAmfComponentErrorReport()), leaving the process unmanaged by AMF.
> ---
> samples/amf/sa_aware/amf_demo_script | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/samples/amf/sa_aware/amf_demo_script
> b/samples/amf/sa_aware/amf_demo_script
> index eb61ac0..a033f53 100755
> --- a/samples/amf/sa_aware/amf_demo_script
> +++ b/samples/amf/sa_aware/amf_demo_script
> @@ -34,6 +34,7 @@ fi
> # Source LSB functions library
> . /lib/lsb/init-functions
>
> +piddir="/tmp"
> compname=`echo $SA_AMF_COMPONENT_NAME | md5sum | awk '{print $1}'`
> pidfile="$piddir/${compname}.pid"
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
