Summary: log: refactor handling IMM in log service - 1st inc [#2149] Review request for Ticket(s): 2149 Peer Reviewer(s): All OpenSAF dev Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2149 Private repository: git://git.code.sf.net/u/winhvu/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This is the first increment in the serial of creating C++ IMM wrapper for IMM C APIs. The aims are: - Get rid of void pointer, pointer to poiter or complicated input parameters - Provide easy and simple interfaces to set/get IMM info. revision 6bb4764925392acea53d62fa6160a3d5fb91fa16 Author: Vu Minh Nguyen <[email protected]> Date: Thu, 13 Apr 2017 08:28:44 +0200 log: refactor handling IMM in log service - 1st inc [#2149] Here is the first increment - create C++ IMM wrapper for IMM API. Aim to create simple and easy interfaces for using IMM. Added Files: ------------ src/immwrp/apitest/common.h src/immwrp/apitest/immwrptest.cc src/immwrp/apitest/immwrp_test_classes.xml src/immwrp/apitest/Makefile src/immwrp/apitest/omclassmanagement.cc src/immwrp/apitest/omclassmanagement.h src/immwrp/apitest/omsearchnext.cc src/immwrp/apitest/omsearchnext.h src/immwrp/immom/Makefile src/immwrp/immom/om_class_description_get.cc src/immwrp/immom/om_class_description_get.h src/immwrp/immom/om_class_description_memory_free.cc src/immwrp/immom/om_class_description_memory_free.h src/immwrp/immom/om_class_management.h src/immwrp/immom/om_common.h src/immwrp/immom/om_finalize.cc src/immwrp/immom/om_finalize.h src/immwrp/immom/om_handle.h src/immwrp/immom/om_initialize.cc src/immwrp/immom/om_initialize.h src/immwrp/immom/om_search_finalize.cc src/immwrp/immom/om_search_finalize.h src/immwrp/immom/om_search.h src/immwrp/immom/om_search_init.cc src/immwrp/immom/om_search_init.h src/immwrp/immom/om_search_next.cc src/immwrp/immom/om_search_next.h src/immwrp/Makefile src/immwrp/Makefile.am src/immwrp/README src/immwrp/tests/common.h src/immwrp/tests/Makefile src/immwrp/tests/omclassmanagement_test.cc src/immwrp/tests/omsearchnext_test.cc Complete diffstat: ------------------ Makefile.am | 1 + src/immwrp/Makefile | 22 ++ src/immwrp/Makefile.am | 112 ++++++++ src/immwrp/README | 141 ++++++++++ src/immwrp/apitest/Makefile | 22 ++ src/immwrp/apitest/common.h | 69 +++++ src/immwrp/apitest/immwrp_test_classes.xml | 227 +++++++++++++++ src/immwrp/apitest/immwrptest.cc | 83 ++++++ src/immwrp/apitest/omclassmanagement.cc | 194 +++++++++++++ src/immwrp/apitest/omclassmanagement.h | 23 ++ src/immwrp/apitest/omsearchnext.cc | 311 +++++++++++++++++++++ src/immwrp/apitest/omsearchnext.h | 23 ++ src/immwrp/immom/Makefile | 18 ++ src/immwrp/immom/om_class_description_get.cc | 57 ++++ src/immwrp/immom/om_class_description_get.h | 101 +++++++ .../immom/om_class_description_memory_free.cc | 53 ++++ .../immom/om_class_description_memory_free.h | 48 ++++ src/immwrp/immom/om_class_management.h | 24 ++ src/immwrp/immom/om_common.h | 77 +++++ src/immwrp/immom/om_finalize.cc | 46 +++ src/immwrp/immom/om_finalize.h | 37 +++ src/immwrp/immom/om_handle.h | 24 ++ src/immwrp/immom/om_initialize.cc | 57 ++++ src/immwrp/immom/om_initialize.h | 46 +++ src/immwrp/immom/om_search.h | 25 ++ src/immwrp/immom/om_search_finalize.cc | 46 +++ src/immwrp/immom/om_search_finalize.h | 41 +++ src/immwrp/immom/om_search_init.cc | 90 ++++++ src/immwrp/immom/om_search_init.h | 160 +++++++++++ src/immwrp/immom/om_search_next.cc | 61 ++++ src/immwrp/immom/om_search_next.h | 138 +++++++++ src/immwrp/tests/Makefile | 19 ++ src/immwrp/tests/common.h | 40 +++ src/immwrp/tests/omclassmanagement_test.cc | 204 ++++++++++++++ src/immwrp/tests/omsearchnext_test.cc | 288 +++++++++++++++++++ 35 files changed, 2928 insertions(+) Testing Commands: ----------------- Have Unit Test and basic apitest in place. Refer to README file for using `immwrptest`. Run unitest by `make check` or manually run `testimmwrp` Testing, Expected Results: -------------------------- Tests PASS Conditions of Submission: ------------------------- Ack on the design Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
