Summary: amf: support amf tool command to know AMF cluster/nodes status [#2354]
Review request for Ticket(s): 2354
Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE ***
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2354
Private repository: git://git.code.sf.net/u/praveenmalviya/review

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            n
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   y


Comments (indicate scope for each "y" above):
---------------------------------------------

revision 2a8ff5aaa7dc8c964de5e99343a6ab6b35562925
Author: praveenmalviya <praveen.malv...@oracle.com>
Date:   Fri, 14 Apr 2017 14:36:37 +0530

amf: support amf tool command to know AMF cluster/nodes status [#2354]

With this command, a user can know the status of nodes in AMF cluster.
For example:
1)normal cluster
NODE(AMF)     STATUS
====================
SC-1          UP
SC-2          DOWN

2)During SCs absence:

NODE(AMF)     STATUS
====================
PL-3          SAM
SC-1          DOWN
SC-2          DOWN



Added Files:
------------
 src/amf/tools/amf_cluster_status.cc


Complete diffstat:
------------------
 opensaf.spec.in                     |   1 +
 src/amf/Makefile.am                 |  16 +-
 src/amf/tools/Makefile              |   2 +-
 src/amf/tools/amf_cluster_status.cc | 325 ++++++++++++++++++++++++++++++++++++
 4 files changed, 342 insertions(+), 2 deletions(-)


Testing Commands:
-----------------
run command:
amfclusterstatus

Testing, Expected Results:
--------------------------
1)normal cluster
NODE(AMF)     STATUS
====================
SC-1          UP
SC-2          DOWN

2)During SCs absence:

NODE(AMF)     STATUS
====================
PL-3          SAM
SC-1          DOWN
SC-2          DOWN


Conditions of Submission:
-------------------------
Ack from any reviewer

Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to