Hi! Will you update the documentation (README and PR doc) as well? Now that we move towards continuous delivery we must be careful to keep the documents up-to-date with the code at all times.
thanks, Anders Widell On 05/03/2017 06:37 AM, Gary Lee wrote: > Hi Alex > > The value is only used when the attribute is set to blank. I’ve changed the > comment to make it clearer. > > Thanks > Gary > > On 2/5/17, 11:15 pm, "Alex Jones" <ajo...@genband.com> wrote: > > Gary, > > Shouldn't this be set to true here? > > Alex > > > >> + while ((attr_mod = opdata->param.modify.attrMods[i++]) != nullptr) { > >> + if (!strcmp(attr_mod->modAttr.attrName, > >> "osafAmfRestrictAutoRepairEnable")) { > >> + bool enabled = false; // default to disabled > >> + if (attr_mod->modType != SA_IMM_ATTR_VALUES_DELETE && > >> + attr_mod->modAttr.attrValues != nullptr) { > >> + enabled = > >> + static_cast<bool>(*((SaUint32T *)attr_mod->modAttr.attrValues[0])); > >> + } > >> + TRACE("osafAmfRestrictAutoRepairEnable changed to '%d'", enabled); > >> + configuration->restrict_auto_repair(enabled); > >> + } > >> + } > >> + TRACE_LEAVE(); > >> +} > > > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Opensaf-devel mailing list > Opensaf-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensaf-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel