Summary: log: fix agent gets TRY_AGAIN instead TIMEOUT during failover [#2411] Review request for Ticket(s): 2411 Peer Reviewer(s): Lennart, Vu, Mahesh Pull request to: Vu Affected branch(es): all branches Development branch: ticket-2411 Base revision: 4cb4351920a16284ac3dfb40f055bab455e760dc Personal repository: git://git.code.sf.net/u/canht32/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 02bc316879a3d94aa3653ff07af17ea9a967bde1 Author: Canh Van Truong <[email protected]> Date: Fri, 5 May 2017 13:32:49 +0200 log: fix agent gets TRY_AGAIN instead TIMEOUT during failover [#2411] During testing, e.g: use saflogger in loop to send a log record to log service during failover, we frequently encounter saLogStreamClose() or saLogFinalize() get SA_AIS_ERR_TIMEOUT as active LOG service is shutdown while agent requests still remain in mailbox. The close request has come to active LOG, means it is put to the mailbox but not yet pick up out for processing yet as LOGsv is just getting TERM signal, then short time later, it does kill itself. The LOG agent did not get the ACK response for sync close request, and after 10s expired, MDS returns TIMEOUT back to the log agent. The solution for this is that, before calling daemon_exit, iterate all items in its mailbox, if that is agent request, send response with try again error to agent before going to shutdown Complete diffstat: ------------------ src/log/logd/lgs_cb.h | 1 + src/log/logd/lgs_evt.cc | 25 ++++++++++++++----------- src/log/logd/lgs_main.cc | 8 ++++++++ 3 files changed, 23 insertions(+), 11 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: ------------------------- Ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
