Summary: amfd: Fix problem of assignment failover while stopping both SCs [#2416] Review request for Ticket(s): 2416 Peer Reviewer(s): AMF maintainers Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2416 Base revision: 4cb4351920a16284ac3dfb40f055bab455e760dc Personal repository: git://git.code.sf.net/u/minh-chau/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 1bca14161e3af03d18f9675eba354a91da92731e Author: Minh Chau <[email protected]> Date: Tue, 9 May 2017 16:21:32 +1000 amfnd: Ignore susi_assign_evh while active amfd is down [#2416] revision f096a3b5ad945369f6fcc07789310a114007d7e3 Author: Minh Chau <[email protected]> Date: Tue, 9 May 2017 16:08:53 +1000 amfd: Add iteration to failover all absent assignments [#2416] Problem: As described in previous patch: "amfd: Make creation and deletion of assignment object as IMM synced call [#2416]" The previous patch makes creation and deletion assignment object as IMM synced call at the first try. It acts as the prevention of inconsistency between AMFND and IMM. However, if the first IMM call fails, a chance of same problem can happen. This patch continues the approach of absent assignments that is using node_fail() Sg Fsm to perform failover. This node_fail() now also is used as a clean up method that iterates and remove all absent invalid assignments as well as failover valid assignments. revision 2732f0210ab590681987aa57f1e84cef3b2e5a60 Author: Minh Chau <[email protected]> Date: Tue, 9 May 2017 16:07:25 +1000 amfd: Make creation and deletion of assignment object as IMM synced call [#2416] If 2N application has each SU hosted on each node and SC Absence feature is enabled, the event of abruptly stopping both SCs will generate assignment failover. At this moment, IMM calls to create/delete assignment object are queued up and executed periodically. Therefore, when both SC are going down, the assignment from AMFND and IMM are pretty unconsistent. The patch makes IMM calls to create and delete assignment objects as synced call. Firstly active AMFD will try to execute IMM calls, if the calls fail then those calls will be queued. Complete diffstat: ------------------ src/amf/amfd/cluster.cc | 7 +++-- src/amf/amfd/imm.cc | 79 ++++++++++++++++++++++++++++++++++++++++++------- src/amf/amfd/imm.h | 5 +++- src/amf/amfd/sg.cc | 23 ++++++++++---- src/amf/amfd/si.cc | 20 ++++++++++--- src/amf/amfd/siass.cc | 15 ++++++---- src/amf/amfd/su.cc | 42 ++++++++++++++++++++++---- src/amf/amfd/su.h | 1 + src/amf/amfnd/su.cc | 6 +++- 9 files changed, 162 insertions(+), 36 deletions(-) Testing Commands: ----------------- Loading the model attached in ticket TC1: Stop both SCs (without shutdown) TC2: Swap 2N SI, stop both SCs Perform the above 2 TCs with below patch only: amfd: Make creation and deletion of assignment object as IMM synced call => This is to test the IMM synced call Perform the above 2 TCs with below patch only: amfd: Add iteration to failover all absent assignments [#2416] => This is to test the failover of all absent assignments with assumption of the creation/deletion of assignment objects being queued. Perform the above 2 TCs with all 3 patches => Put all together and test again Testing, Expected Results: -------------------------- All runs shall pass Conditions of Submission: ------------------------- ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
