Summary: clm: add tool commands clm-adm, clm-state, clm-find [#2394] V2
Review request for Ticket(s): 2394
Peer Reviewer(s): Anders
Pull request to: myself
Affected branch(es): develop
Development branch: ticket-2394
Base revision: 07c29e4ca862bb72a12f86a21f08945ffe8e8ce1
Personal repository: git://git.code.sf.net/u/praveenmalviya/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other y
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
This is v2. It incoporates comments given by Anders.
revision 3ab116bfaa6036b9ba70776d25a851ea1f2f81e5
Author: Praveen <praveen.malv...@oracle.com>
Date: Fri, 12 May 2017 15:09:30 +0530
clm: add tool commands clm-adm, clm-state, clm-find [#2394]
This is V2 which incorporates comments given on V1.
clm-adm: for performing CLM admin operations on CLM node and cluser.
clm-find: for finding out object(s) configured for CLM classes SaClmCluster
and SaClmNode. Additional options like membership status and admin
state
can also be given to find out objects which satisfy this criteria.
clm-state: for listing CLM node(s) and their important attributes.
Added Files:
------------
src/clm/tools/clm-adm
src/clm/tools/clm-find
src/clm/tools/clm-state
Complete diffstat:
------------------
opensaf.spec.in | 3 +
src/clm/Makefile.am | 5 ++
src/clm/tools/clm-adm | 105 ++++++++++++++++++++++++++++++++++
src/clm/tools/clm-find | 84 +++++++++++++++++++++++++++
src/clm/tools/clm-state | 148 ++++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 345 insertions(+)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
Ack from Anders.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
