The review script now checks for trailing whitespace. When I put in the
official SA-Forum header, it had some trailing whitespace.

Alex

On 05/22/2017 01:21 AM, Mathi N P wrote:
> ------------------------------------------------------------------------
> NOTICE: This email was received from an EXTERNAL sender
> ------------------------------------------------------------------------
> 
> Iam not sure what is being in changed in the header file?
> Ack,
> Mathi.
> 
> On Thu, May 11, 2017 at 6:50 PM, Alex Jones <[email protected]
> <mailto:[email protected]>> wrote:
> 
>     Fix whitespace issues.
>     ---
>      src/lck/saf/saLck.h | 46 +++++++++++++++++++++++-----------------------
>      1 file changed, 23 insertions(+), 23 deletions(-)
> 
>     diff --git a/src/lck/saf/saLck.h b/src/lck/saf/saLck.h
>     index f0ff90a..4786794 100644
>     --- a/src/lck/saf/saLck.h
>     +++ b/src/lck/saf/saLck.h
>     @@ -3,19 +3,19 @@
>      ** FILE:
>      **   saLck.h
>      **
>     -** DESCRIPTION:
>     -**   This file provides the C language binding for the Service
>     -**   Availability(TM) Forum AIS Lock Service (LCK). It contains all of
>     -**   the prototypes and type definitions required for LCK.
>     -**
>     +** DESCRIPTION:
>     +**   This file provides the C language binding for the Service
>     +**   Availability(TM) Forum AIS Lock Service (LCK). It contains all of
>     +**   the prototypes and type definitions required for LCK.
>     +**
>      ** SPECIFICATION VERSION:
>      **   SAI-AIS-LCK-B.03.01
>      **
>     -** DATE:
>     +** DATE:
>      **   Thu Jul 16 2009
>      **
>      ** LEGAL:
>     -**   OWNERSHIP OF SPECIFICATION AND COPYRIGHTS.
>     +**   OWNERSHIP OF SPECIFICATION AND COPYRIGHTS.
>      **
>      ** Copyright(c) 2009, Service Availability(TM) Forum. All rights
>     reserved.
>      **
>     @@ -79,26 +79,26 @@ typedef enum {
>          SA_LCK_MAX_NUM_LOCKS_ID = 1
>      } SaLckLimitIdT;
> 
>     -typedef void
>     +typedef void
>      (*SaLckResourceOpenCallbackT)(
>          SaInvocationT invocation,
>          SaLckResourceHandleT lockResourceHandle,
>          SaAisErrorT error);
> 
>     -typedef void
>     +typedef void
>      (*SaLckLockGrantCallbackT)(
>          SaInvocationT invocation,
>          SaLckLockStatusT lockStatus,
>          SaAisErrorT error);
> 
>     -typedef void
>     +typedef void
>      (*SaLckLockWaiterCallbackT)(
>          SaLckWaiterSignalT waiterSignal,
>          SaLckLockIdT lockId,
>          SaLckLockModeT modeHeld,
>          SaLckLockModeT modeRequested);
> 
>     -typedef void
>     +typedef void
>      (*SaLckResourceUnlockCallbackT)(
>          SaInvocationT invocation,
>          SaAisErrorT error);
>     @@ -114,32 +114,32 @@ typedef struct {
>      /******** LCK API function declarations **********/
>      /*************************************************/
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckInitialize(
>     -    SaLckHandleT *lckHandle,
>     +    SaLckHandleT *lckHandle,
>          const SaLckCallbacksT *lckCallbacks,
>          SaVersionT *version);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckSelectionObjectGet(
>          SaLckHandleT lckHandle,
>          SaSelectionObjectT *selectionObject);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckOptionCheck(
>          SaLckHandleT lckHandle,
>          SaLckOptionsT *lckOptions);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckDispatch(
>          SaLckHandleT lckHandle,
>          SaDispatchFlagsT dispatchFlags);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckFinalize(
>          SaLckHandleT lckHandle);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckResourceOpen(
>          SaLckHandleT lckHandle,
>          const SaNameT *lockResourceName,
>     @@ -147,18 +147,18 @@ saLckResourceOpen(
>          SaTimeT timeout,
>          SaLckResourceHandleT *lockResourceHandle);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckResourceOpenAsync(
>          SaLckHandleT  lckHandle,
>          SaInvocationT invocation,
>          const SaNameT *lockResourceName,
>          SaLckResourceOpenFlagsT resourceFlags);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckResourceClose(
>          SaLckResourceHandleT lockResourceHandle);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckResourceLock(
>          SaLckResourceHandleT lockResourceHandle,
>          SaLckLockIdT  *lockId,
>     @@ -177,12 +177,12 @@ saLckResourceLockAsync(
>          SaLckLockFlagsT lockFlags,
>          SaLckWaiterSignalT waiterSignal);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckResourceUnlock(
>          SaLckLockIdT lockId,
>          SaTimeT timeout);
> 
>     -extern SaAisErrorT
>     +extern SaAisErrorT
>      saLckResourceUnlockAsync(
>          SaInvocationT invocation,
>          SaLckLockIdT lockId);
>     --
>     2.7.4
> 
> 

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to