Ack, code review only/Thanks HansN
-----Original Message-----
From: Gary Lee [mailto:[email protected]]
Sent: den 24 maj 2017 02:52
To: praveen malviya <[email protected]>; Hans Nordebäck
<[email protected]>; Minh Hon Chau <[email protected]>;
[email protected]
Cc: [email protected]; Gary Lee <[email protected]>
Subject: [PATCH 1/1] amfd: only increment su_cnt_admin_oper for non-opensaf SUs
[#2466]
Only increment su_cnt_admin_oper for non-opensaf SUs. Otherwise a nodegroup
admin operation may fail to finish if it is started while a node is joining.
based on analysis from Minh / Praveen
---
src/amf/amfd/sgproc.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/amf/amfd/sgproc.cc b/src/amf/amfd/sgproc.cc index
cd95fe82c..20549808b 100644
--- a/src/amf/amfd/sgproc.cc
+++ b/src/amf/amfd/sgproc.cc
@@ -262,6 +262,7 @@ npisu_done:
AVD_AVND *node = su->su_on_node;
if ((node->admin_node_pend_cbk.invocation != 0) ||
((node->admin_ng != nullptr) &&
+ (su->sg_of_su->sg_ncs_spec == false) &&
(node->admin_ng->admin_ng_pend_cbk.invocation != 0))) {
node->su_cnt_admin_oper++;
TRACE("node:'%s', su_cnt_admin_oper:%u", node->name.c_str(),
--
2.11.0
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
