Summary: clmd: update saClmNodeCurrAddress and saClmNodeCurrAddressFamily in
IMM [#2331]
Review request for Ticket(s): 2331
Peer Reviewer(s): Anders,Tai Dinh
Pull request to: myself
Affected branch(es): develop
Development branch: ticket-2331
Base revision: 40b8e4a53b9d5555e7efbda2e7eb141da4701df7
Personal repository: git://git.code.sf.net/u/praveenmalviya/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision ab662d40a38397fb5732d45fe99cca02e4823199
Author: Praveen <praveen.malv...@oracle.com>
Date: Fri, 26 May 2017 12:06:52 +0530
clmd: update saClmNodeCurrAddress and saClmNodeCurrAddressFamily in IMM [#2331]
CLM gets ip address and address family from MDS in node up event.
When node will join CLM cluster, CLM will update saClmNodeCurrAddress and
saClmNodeCurrAddressFamily in IMM.
Also changed permission of CLM tool commands.
Complete diffstat:
------------------
src/clm/clmd/clms_imm.c | 21 +++++++++++++++++++--
src/clm/clmd/clms_mds.c | 35 +++++++++++++++++++++++++----------
src/clm/tools/clm-adm | 0
src/clm/tools/clm-find | 0
src/clm/tools/clm-state | 0
5 files changed, 44 insertions(+), 12 deletions(-)
Testing Commands:
-----------------
for i in `clm-find `; do echo "";echo $i; immlist $i | grep -i CurrAddress; done
Testing, Expected Results:
--------------------------
safNode=SC-1,safCluster=myClmCluster
saClmNodeCurrAddressFamily SA_UINT32_T 1 (0x1)
saClmNodeCurrAddress SA_STRING_T 192.168.56.151
safNode=SC-2,safCluster=myClmCluster
saClmNodeCurrAddressFamily SA_UINT32_T 1 (0x1)
saClmNodeCurrAddress SA_STRING_T 192.168.56.152
Conditions of Submission:
-------------------------
Ack from atleast one reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 y n
x86_64 n y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
