Summary: amf: support for sc status change callback, non SAF [#2475]
Review request for Ticket(s): 2475
Peer Reviewer(s): AMF devs
Pull request to: myself
Affected branch(es): develop
Development branch: ticket-2475
Base revision: 9e88cc8b28bee6e65c934961064b7125a8221bcb
Personal repository: git://git.code.sf.net/u/praveenmalviya/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 7967d6c1dfa0a37b428f24e75ad41c0b920f202e
Author: Praveen <praveen.malv...@oracle.com>
Date: Thu, 1 Jun 2017 17:00:10 +0530
amf: add a sample app for SC status change callback [#2475]
revision e7c953c588a08068cf8c49927abb8b86aaa1c12a
Author: Praveen <praveen.malv...@oracle.com>
Date: Thu, 1 Jun 2017 16:59:26 +0530
amf: support SC status change callback, non SAF [#2475]
* A callback that will be invoked by AMFA whenever a SC joins cluster and
both SCs leaves cluster if SC Absence feature is enabled.
Callback and its argument:
void (*OsafAmfSCStatusChangeCallbackT)(OsafAmfSCStatusT state)
where OsafAmfSCStatusT is defined as:
typedef enum {
OSAF_AMF_SC_PRESENT = 1,
OSAF_AMF_SC_ABSENT = 2,
} OsafAmfSCStatusT;
This callback can be integrated
with standard AMF component (even with legacy one also).
* An API to register/install above callback function:
void osafAmfInstallSCStatusChangeCallback(
void (*OsafAmfSCStatusChangeCallbackT)(OsafAmfSCStatusT status));
revision c637c41c3cc365f8a2b1e85887b0769f285eb60b
Author: Praveen <praveen.malv...@oracle.com>
Date: Thu, 1 Jun 2017 16:56:21 +0530
amf: update readme for SC status change callback [#2475]
Added Files:
------------
samples/amf/sa_aware/amf_sc_status_app.c
Complete diffstat:
------------------
samples/amf/sa_aware/Makefile.am | 13 +++-
samples/amf/sa_aware/README | 8 +++
samples/amf/sa_aware/amf_sc_status_app.c | 115 +++++++++++++++++++++++++++++++
src/amf/README_SC_ABSENCE | 29 ++++++++
src/amf/agent/ava_mds.cc | 35 +++++++++-
src/amf/agent/ava_mds.h | 6 +-
src/amf/agent/ava_op.cc | 5 ++
src/amf/amfnd/avnd_mds.h | 2 +-
src/amf/amfnd/di.cc | 39 ++++++++++-
src/amf/amfnd/mds.cc | 5 +-
src/amf/common/amf_amfparam.h | 7 ++
src/amf/common/amf_n2avamsg.h | 1 +
src/amf/saf/libSaAmf.map | 1 +
src/amf/saf/saAmf_B_04_02.h | 8 +++
14 files changed, 267 insertions(+), 7 deletions(-)
Testing Commands:
-----------------
Tested the demo packaged in patch 3
Testing, Expected Results:
--------------------------
Pass
Conditions of Submission:
-------------------------
ack from reviewers if they like it.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
