Summary: amfd: skip unassigned SUSIs in SU for updating saAmfSUAssignedSIs
[#2496]
Review request for Ticket(s): 2496
Peer Reviewer(s): AMF devs
Pull request to: myself
Affected branch(es): develop
Development branch: ticket-2496
Base revision: db1965d634eac2f375f455b7b7d3e9f70ff0c47c
Personal repository: git://git.code.sf.net/u/praveenmalviya/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 3a71aa41a6708b3605c0f66fde17447ddd545cd1
Author: Praveen <praveen.malv...@oracle.com>
Date: Wed, 14 Jun 2017 16:26:56 +0530
amfd: skip unassigned SUSIs in SU for updating saAmfSUAssignedSIs [#2496]
In the reported problem, AMFD crashes while trying to free invalid memory.
AMFD is trying to update value of saAmfSUAssignedSIs to IMM.
SU assignments counters saAmfSUNumCurrActiveSIs and saAmfSUNumCurrStandbySIs
reflects only active and standby HA state. If a SI is in quiesced state, it
is still assigned to this SU and su->list_of_susi will not be null. But
saAmfSUNumCurrActiveSIs will be 0.
Thus in the reported problem, no memory allocation was done
and AMFD will crash while freeing invalid memory.
Patch counts all those SUSIs which are not in unassigned fsm state in SU.
A SUSI with fsm state unassigned is getting deleted and thus not counted.
Complete diffstat:
------------------
src/amf/amfd/su.cc | 28 ++++++++++++++++++++++++----
src/amf/amfd/su.h | 1 +
2 files changed, 25 insertions(+), 4 deletions(-)
Testing Commands:
-----------------
Tested as per ticket description.
Testing, Expected Results:
--------------------------
No crash observed
Conditions of Submission:
-------------------------
Ack from any reviewer.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
