Ack with comment: the directory /var/lock/subsys is created by the same
script (/etc/init.d/opensafd) in the function check_env(), which is
called after the function mutex_create(). Because of this, I get the
following error when testing the patch in UML:
# mkdir: can't create directory '/var/lock/subsys/opensafd_inprogress':
No such file or directory
opensafd start/stop in progress. Waiting for lockfile to be removed ...
(warning).
mkdir: can't create directory '/var/lock/subsys/opensafd_inprogress': No
such file or directory
mkdir: can't create directory '/var/lock/subsys/opensafd_inprogress': No
such file or directory
mkdir: can't create directory '/var/lock/subsys/opensafd_inprogress': No
such file or directory
mkdir: can't create directory '/var/lock/subsys/opensafd_inprogress': No
such file or directory
opensafd start/stop already in progress. Unable to continue ... (warning).
To forcefully start/stop OpenSAF remove
/var/lock/subsys/opensafd_inprogress ... (warning).
I think you need to make sure that /var/lock/subsys is created before
mutex_create() is called.
regards,
Anders Widell
On 06/08/2017 12:29 PM, Rafael Odzakow wrote:
Summary: base: Try again for opensafd stop [#2459]
Review request for Ticket(s): 2459
Peer Reviewer(s): anders/hans
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2459
Base revision: 664e46e54ef3c4b2e11b84e5efc73916ba6f6fc2
Personal repository: git://git.code.sf.net/u/erafodz/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
Changed according to comments. Tested
revision 29bb1d48b59cad1fed1b76ac276afde4d77847f9
Author: Rafael Odzakow <[email protected]>
Date: Thu, 8 Jun 2017 12:24:35 +0200
base: Try again for opensafd stop [#2459]
Internally opensafd creates a mutex during start/stop to avoid parallel
execution. Makes mutex more robust and add a short retry if mutex is
taken.
Complete diffstat:
------------------
src/nid/opensafd.in | 155 +++++++++++++++++++++++++++++-----------------------
1 file changed, 88 insertions(+), 67 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
