Hi! Did you get a chance to look at tickets [#2502] and [#2472] yet?
If there are no comments I would like to push them by the end of this week. thanks, Anders Widell On 06/20/2017 10:57 AM, Anders Widell wrote:
Summary: osaf: Fix build problems when using GCC 7.1.1 [#2502] Review request for Ticket(s): 2502 Peer Reviewer(s): Mahesh Pull request to: Affected branch(es): develop Development branch: ticket-2502 Base revision: da08a820a03d8bf6b3ea35bf318a207eba57356f Personal repository: git://git.code.sf.net/u/anders-w/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision e53a35b9875841a5336fa6eef312332fa786568c Author: Anders Widell <[email protected]> Date: Mon, 19 Jun 2017 15:57:54 +0200 osaf: Fix build problems when using GCC 7.1.1 [#2502] Fix build problems caused by the following warnings: * -Werror=format-overflow= * -Werror=parentheses * -Werror=unused-variable Complete diffstat: ------------------ src/amf/amfd/imm.cc | 2 - src/clm/apitest/tet_ClmLongRdn.c | 24 +++++--- src/clm/apitest/tet_ClmOiOps.c | 72 +++++++++++++--------- src/clm/clmd/clms_imm.c | 6 +- src/clm/clmd/clms_ntf.c | 23 ++++--- src/imm/apitest/implementer/test_SaImmOiCcb.c | 21 ++++--- .../implementer/test_saImmOiRtObjectCreate_2.c | 12 ++-- .../management/test_saImmOmCcbObjectDelete.c | 12 ++-- .../management/test_saImmOmCcbObjectModify_2.c | 12 ++-- src/ntf/apitest/tet_longDnObject_notification.c | 18 +++--- 10 files changed, 125 insertions(+), 77 deletions(-) Testing Commands: ----------------- Build OpenSAF using GCC version 7.1 or later Testing, Expected Results: -------------------------- OpenSAF shall build successfully. Conditions of Submission: ------------------------- Ack from reviewer(s). Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
