I am reviewing the patches.
Thanks,
Praveen
On 24-Jul-17 7:27 PM, Anders Widell wrote:
Summary: clm: Make it possible for a node to scale out itself using autoscaling
[#2509]
Review request for Ticket(s): 2509
Peer Reviewer(s): Praveen
Pull request to:
Affected branch(es): develop
Development branch: ticket-2509
Base revision: de977bacba9b452fe2a8abcae26a1188a7a15f31
Personal repository: git://git.code.sf.net/u/anders-w/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 7782f5e526729b97a973e11feb52105c120fe2ce
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 24 Jul 2017 15:41:51 +0200
clm: Make it possible for a node to scale out itself using autoscaling [#2509]
Ticket [#1453] added support for autoscaling, which allows scale-out from an
initial cluster containing at least one node. This commit adds support for
scaling out from a cluster containing zero nodes, or alternatively, a cluster
where the active node is not a configured node. The use cases are as follows:
* Support loading a backup that was created on a different cluster where none of
the new nodes have the same name as any of the nodes in the old cluster.
* Support cluster restart on a system where nodes don't have persistent local
storage (or persistent host names / node names) - i.e. a system where a node
reboot will always result in a scale-in followed by a scale-out
* Make scaling more robust, e.g. imagine a case when a one-node cluster is
scaled out by adding a second node, but then the original node is removed
before scale-out of the new node has completed.
revision 262d4c7a96e663dc00335278df28e0788c19d334
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 24 Jul 2017 15:41:15 +0200
ntf: Re-try initializing CLM on unconfigured nodes [#2509]
Re-try initializing the CLM API when it returns SA_AIS_ERR_UNAVAILABLE, so that
the NTF service properly waits for the node to become configured by the
autoscaling functionality.
revision 2e2f4dd43621a1113262caf274bac4989f2d9d7d
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 24 Jul 2017 15:34:47 +0200
log: Re-try initializing CLM on unconfigured nodes [#2509]
Re-try initializing the CLM API when it returns SA_AIS_ERR_UNAVAILABLE. This
error code is returned if the LOG service has been started on an unconfigured
node, which may happen for a while when the autoscaling feature is used.
revision 31305c94edb9eae1aecc66c6d13105324ffcfa1b
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 24 Jul 2017 15:32:24 +0200
amf: Log CLM initialization error only once on unconfigured nodes [#2509]
Avoid spamming the syslog with more than one log message in case CLM returns
SA_AIS_ERR_UNAVAILABLE (i.e. we are running on a currently unconfigured node).
Complete diffstat:
------------------
src/amf/amfd/clm.cc | 6 ++++--
src/amf/amfnd/clm.cc | 6 ++++--
src/clm/clmd/clms_main.c | 12 ++++++++++--
src/log/logd/lgs_clm.cc | 3 ++-
src/ntf/ntfd/ntfs_clm.c | 3 ++-
5 files changed, 22 insertions(+), 8 deletions(-)
Testing Commands:
-----------------
Enable autoscaling in clmd.conf and by removing the "exit" command from
opensaf_scale_out script. Start a cluster where none of the nodes are configured
in IMM.
Testing, Expected Results:
--------------------------
The nodes shall be scaled out.
Conditions of Submission:
-------------------------
Ack from reviewer(s)
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
