Hi! Did you get a chance to look at this yet?
thanks, Anders Widell On 07/31/2017 03:10 PM, Anders Widell wrote:
Summary: clm: Include boot time and node address in join request message [#2489] Review request for Ticket(s): 2489 Peer Reviewer(s): Praveen Pull request to: Affected branch(es): develop Development branch: ticket-2489 Base revision: 10b4c9e2f952456c3ef7c4413e224c3365e4b18f Personal repository: git://git.code.sf.net/u/anders-w/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- NOTE: This ticket depens on ticket [#2535] which is still out on review. revision 56e7a62729974e03f3cd441a182121ea67937136 Author: Anders Widell <[email protected]> Date: Mon, 31 Jul 2017 14:02:07 +0200 clm: Include boot time and node address in join request message [#2489] The node join request message now has two new fields: boot time and node address. This allows us to provide more accurate and correct information in the CLM node runtime attributes in the information model: * The boot time field transmits the node's actual boot time to the CLM server. Previously, the node join time was used as an approximation of the node boot time, but this might be inaccurate or incorrect. For example, if OpenSAF was started much later than the node was booted (e.g. if OpenSAF was restarted without a node reboot), then the node join time will differ significantly from the node boot time. * The node address field transmits the node address to be presented to the application through the information model. Previously, the IP address which was used by OpenSAF internal communication was presented as the one and only node address, and there was no way to select some other address in case the node has multiple network addresses. The application now has the possibility to select which network address to present in the information model. Complete diffstat: ------------------ 00-README.conf | 8 ++++ src/clm/clmd/clms.h | 1 - src/clm/clmd/clms_evt.c | 15 ++++++- src/clm/clmd/clms_main.c | 22 ++++++---- src/clm/clmd/clms_mbcsv.c | 11 ++--- src/clm/clmd/clms_mbcsv.h | 2 - src/clm/clmd/clms_mds.c | 92 +++++++++++++++++++++++++----------------- src/clm/clmd/clms_util.c | 15 ------- src/clm/clmnd/cb.h | 14 ++++--- src/clm/clmnd/clmna.conf | 13 ++++++ src/clm/clmnd/main.c | 89 ++++++++++++++++++++++++++++++++-------- src/clm/common/clmsv_enc_dec.c | 34 +++++++++++++++- src/clm/common/clmsv_enc_dec.h | 2 + src/clm/common/clmsv_msg.h | 5 +++ 14 files changed, 232 insertions(+), 91 deletions(-) Testing Commands: ----------------- For boot time: Make a note of saClmNodeBootTimeStamp for a node in the cluster. Run /etc/init.d/opensafd stop followed by /etc/init.d/opensafd start on that node. Check saClmNodeBootTimeStamp of that node again. The time stamp shall not be affected by restarting OpenSAF (without a node reboot). For node address: Configure OpenSAF to use TIPC for internal communication. Set CLMNA_ADDR_FAMILY and CLMNA_ADDR_VALUE in /etc/opensaf/clmna.conf for a node in the cluster. Start the node. Check saClmNodeCurrAddressFamily and saClmNodeCurrAddress of that node. The values shall match what you entered in /etc/opensaf/clmna.conf. Testing, Expected Results: -------------------------- See above. Conditions of Submission: ------------------------- Ack from reviewer(s) Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
