Ack. Minor comments in attached.diff file. See tag [Lennart] Thanks Lennart
> -----Original Message----- > From: Canh Van Truong [mailto:[email protected]] > Sent: den 20 juli 2017 08:31 > To: Lennart Lund <[email protected]>; Vu Minh Nguyen > <[email protected]>; [email protected] > Cc: [email protected]; Canh Van Truong > <[email protected]> > Subject: [PATCH 0/1] Review Request for log: fix cppcheck, cpplint and > reorganize headers - part 1 [#2445] > > Summary: log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445] > Review request for Ticket(s): 2445 > Peer Reviewer(s): Lennart, Vu, Mahesh > Pull request to: Vu > Affected branch(es): develop > Development branch: ticket-2445 > Base revision: 653edb5d9b217f1a3280b5aed8597fb53ffa5f61 > Personal repository: git://git.code.sf.net/u/canht32/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > revision 8a7192da8b78065734da197211f19d4914706926 > Author: Canh Van Truong <[email protected]> > Date: Thu, 20 Jul 2017 13:21:52 +0700 > > log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445] > > Fix cppcheck, cpplint, replace nullptr for following files: > - lgs_amf.*, lgs_config.*, lgs_dest.*, lgs_evt.*, lgs_file.*, > lgs_filehdl.*, lgs_nildest.*, lgs_unixsock_dest.* > lgs_util.*, lgs_dest_test.* > > > > Complete diffstat: > ------------------ > src/log/logd/lgs_amf.cc | 25 ++-- > src/log/logd/lgs_config.cc | 238 > +++++++++++++++------------------------ > src/log/logd/lgs_config.h | 3 +- > src/log/logd/lgs_dest.cc | 2 +- > src/log/logd/lgs_dest.h | 6 +- > src/log/logd/lgs_evt.cc | 111 +++++++++--------- > src/log/logd/lgs_evt.h | 17 ++- > src/log/logd/lgs_file.cc | 56 +++++---- > src/log/logd/lgs_filehdl.cc | 84 +++++++------- > src/log/logd/lgs_nildest.h | 6 +- > src/log/logd/lgs_recov.cc | 4 +- > src/log/logd/lgs_stream.cc | 16 +-- > src/log/logd/lgs_unixsock_dest.h | 6 +- > src/log/logd/lgs_util.cc | 58 +++++----- > src/log/logd/lgs_util.h | 7 +- > src/log/tests/lgs_dest_test.cc | 2 +- > 16 files changed, 293 insertions(+), 348 deletions(-) > > > Testing Commands: > ----------------- > *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** > > > Testing, Expected Results: > -------------------------- > *** PASTE COMMAND OUTPUTS / TEST RESULTS *** > > > Conditions of Submission: > ------------------------- > Ack from reviewer > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email > etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual.
Lennart_comments.diff
Description: Lennart_comments.diff
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
