As a general principle, we should never assert (or crash) due to the reception of unexpected or corrupted data over the network. So the assertion should be removed. But you are right that we need to do something sensible here. Maybe log an error message and terminate the connection to the node that sent the message?

regards,

Anders Widell


On 08/09/2017 05:33 AM, A V Mahesh wrote:
Hi Alex,

You removed osafassert(0); and event `rc` is not updated to NCSCC_RC_FAILURE; why you what proceed for when node_id=0.

node->node_id can be zero because of other factors, please check.

-AVM

On 8/8/2017 11:42 PM, Alex Jones wrote:
Sep 13 14:00:52 SC-2 local0.err osafdtmd[378]: ER DTM: Node already exit in the cluster with smiler configuration , correct the other joining Node configuration

The message is confusing.

Reword it to make it clear that there is a possible duplicate IP address.
---
  src/dtm/dtmnd/dtm_node.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/dtm/dtmnd/dtm_node.c b/src/dtm/dtmnd/dtm_node.c
index ac762d0..236ae65 100644
--- a/src/dtm/dtmnd/dtm_node.c
+++ b/src/dtm/dtmnd/dtm_node.c
@@ -110,8 +110,7 @@ uint32_t dtm_process_node_info(DTM_INTERNODE_CB *dtms_cb, int stream_sock,
              node->comm_status = true;
              if (dtm_node_add(node, 0) != NCSCC_RC_SUCCESS) {
                  LOG_ER(
- "DTM: Node already exit in the cluster with smiler configuration , correct the other joining Node configuration ");
-                osafassert(0);
+ "DTM: A node already exists in the cluster with similar configuration (possible duplicate IP address and/or node id), please correct the other joining Node configuration ");
              }
            } else if (node->node_id == node_id) {



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to