Summary: amfa: Fix api internal check to avoid fatal mutex unlock [#2548]
Review request for Ticket(s): 2548
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): develop, release
Development branch: ticket-2548
Base revision: 8a15fb881c238d4e3246d97d7e5201e5ae235af5
Personal repository: git://

Impacted area       Impact y/n
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n

Comments (indicate scope for each "y" above):
revision 93aa170d6896c1eac5bd8cd9ac004b7da04c1a07
Author: Nguyen Luu <>
Date:   Fri, 11 Aug 2017 14:51:31 +0700

amfa: Fix api internal check to avoid fatal mutex unlock [#2548]

Current check for the required setting of the SA_AMF_COMPONENT_NAME
env variable in some amf api's (ComponentRegister, QuiescingComplete)
would crash the invoking process if that env variable was missed
to be set for some reason, as the agent lib tries, during cleanup,
to unlock a mutex which it has not previously locked yet.

Complete diffstat:
 src/amf/agent/ | 51 ++++++++++++++++++++++++++++------------------
 1 file changed, 31 insertions(+), 20 deletions(-)

Testing Commands:
First call saAmfInitialize, then call saAmfComponentRegister without having
previously set the environment variable SA_AMF_COMPONENT_NAME.

Testing, Expected Results:
saAmfComponentRegister should return SA_AIS_ERR_LIBRARY.

Conditions of Submission:
Ack from reviewers of after 2 weeks.

Arch      Built     Started    Linux distro
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y
powerpc     n          n
powerpc64   n          n

Reviewer Checklist:
[Submitters: make sure that your review doesn't trigger any checkmarks!]

Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.gitconfig file (i.e., etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.

Check out the vibrant tech community on one of the world's most
engaging tech sites,!
Opensaf-devel mailing list

Reply via email to