Summary: dtm: Re-factor the inter-node receive logic [#2554] Review request for Ticket(s): 2554 Peer Reviewer(s): Mahesh, Alex Pull request to: Affected branch(es): develop Development branch: ticket-2554 Base revision: 96c76894317e699b1a87664e2d8d98e900487625 Personal repository: git://git.code.sf.net/u/anders-w/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- revision 2b4b4b2fd0f70381832ffff093dd09d4a75208c0 Author: Anders Widell <[email protected]> Date: Mon, 21 Aug 2017 10:45:27 +0200 dtm: Re-factor the inter-node receive logic [#2554] The DTM receive logic was unnecessarily complex: it called recv() in many different places and had conditional statements that executed different pieces of code depending on how many bytes that had been received on the stream socket so far. The code has now been refactored so that it uses only one single recv() statement and one single check to determine if it has received a full message or not. Complete diffstat: ------------------ src/dtm/dtmnd/dtm_cb.h | 8 +- src/dtm/dtmnd/dtm_inter.h | 3 + src/dtm/dtmnd/dtm_node.c | 360 ++++++++++++++------------------------------ src/dtm/dtmnd/dtm_node_db.c | 16 +- 4 files changed, 128 insertions(+), 259 deletions(-) Testing Commands: ----------------- Run regression tests with OpenSAF configured to use the TCP transport. Testing, Expected Results: -------------------------- Regression tests shall pass. Conditions of Submission: ------------------------- Ack from reviewer(s). Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
