Summary: amfnd: fix opensaf shutdown and active monitoring failure [#2493] Review request for Ticket(s): 2493 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): develop Development branch: ticket-2493 Base revision: 254f6a9081607d6c8a7412ebdfd11ede090637ae Personal repository: git://git.code.sf.net/u/praveenmalviya/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision 66a94a1962a6c41381b8c2e03b5c066ac6fc155f Author: Praveen <[email protected]> Date: Wed, 30 Aug 2017 14:32:38 +0530 amfnd: fix opensaf shutdown and active monitoring failure [#2493] If active monitoring command is wrongly configured by the user, AMF reports fault on NPI component and AMFND restarts it. Since every time active monitoring command fails, component is getting continuously faulted. When OpenSAF is stopped on this node then amfnd asserted. In the reported issue, continuous fault and recovery of component is not getting escalated to node-failover as compRestartProb is very low. During OpenSAF shutdown, amfnd does not terminate component as a part removal of assignment and deletes ssui. In component clean up phase, amfnd terminates component but does not find si for it and asserts. Patch ensures that AMFND terminates component as a part of removal of assignment during OpenSAF stop. Complete diffstat: ------------------ src/amf/amfnd/susm.cc | 58 ++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 44 insertions(+), 14 deletions(-) Testing Commands: ----------------- Tested as per ticket description. Testing, Expected Results: -------------------------- No crash observed Conditions of Submission: ------------------------- Ack from any reviewers, Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
