Summary: ntf: correct return code is returned [#2039] Review request for Ticket(s): 2039 Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE *** Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2039 Base revision: 3a7855b3d8164a0780158cedcd9a202c7ddea1a1 Personal repository: git://git.code.sf.net/u/sri-mangipudy/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 3b8cac858c9e9a97c9f2697b3d165241d57a8850 Author: Srinivas <[email protected]> Date: Fri, 15 Sep 2017 15:44:53 +0530 ntf: correct return code is returned [#2039] Complete diffstat: ------------------ src/ntf/apitest/tet_scOutage_reinitializeHandle.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** ntftest -v -e 37 Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** ACTIVE Active controller node. Do not run CLM tests Suite 37: SC outage: Test for producer Start test API: saNtfInitialize Next: manually STOP both SCs(in UML env. ./opensaf nodestop <1|2>) Then press 'n' and 'Enter' (or 'pkill -USR2 ntftest') to continue. Waiting ... .......n Running saNtfInitialize()...Done, rc:2 Next: manually START both SCs(in UML env. ./opensaf nodestart <1|2>) Then press 'n' and 'Enter' (or 'pkill -USR2 ntftest') to continue. Waiting ... ................... n Running saNtfInitialize()...Done, rc:2 Running saNtfAlarmNotificationAllocate()...Done, rc:9 Running saNtfSecurityAlarmNotificationAllocate()...Done, rc:9 Running saNtfStateChangeNotificationAllocate()...Done, rc:9 Running saNtfObjectCreateDeleteNotificationAllocate()...Done, rc:9 Running saNtfAttributeChangeNotificationAllocate()...Done, rc:9 Running saNtfNotificationSend()...Done, rc:9 Running saNtfNotificationFree()...Done, rc:9 Running saNtfFinalize()...Done, rc:9 End test API: saNtfInitialize num of failed notifications: 10 1 FAILED Test saNtfInitialize (expected SA_AIS_OK (1), got SA_AIS_ERR_BAD_HANDLE (9)) Start test API: saNtfNotificationSend Running saNtfInitialize()...Done, rc:2 Running saNtfAlarmNotificationAllocate()...Done, rc:9 Running saNtfSecurityAlarmNotificationAllocate()...Done, rc:9 Running saNtfStateChangeNotificationAllocate()...Done, rc:9 Running saNtfObjectCreateDeleteNotificationAllocate()...Done, rc:9 Running saNtfAttributeChangeNotificationAllocate()...Done, rc:9 Next: manually STOP both SCs(in UML env. ./opensaf nodestop <1|2>) Then press 'n' and 'Enter' (or 'pkill -USR2 ntftest') to continue. Waiting ... ........n Running saNtfNotificationSend()...Done, rc:9 Next: manually START both SCs(in UML env. ./opensaf nodestart <1|2>) Then press 'n' and 'Enter' (or 'pkill -USR2 ntftest') to continue. Waiting ... .............n Running saNtfNotificationSend()...Done, rc:9 Running saNtfNotificationFree()...Done, rc:9 Running saNtfFinalize()...Done, rc:9 End test API: saNtfNotificationSend num of failed notifications: 10 2 FAILED Test saNtfNotificationSend (expected SA_AIS_OK (1), got SA_AIS_ERR_BAD_HANDLE (9)) Start test API: saNtfFinalize Running saNtfInitialize()...Done, rc:2 Running saNtfAlarmNotificationAllocate()...Done, rc:9 Running saNtfSecurityAlarmNotificationAllocate()...Done, rc:9 Running saNtfStateChangeNotificationAllocate()...Done, rc:9 Running saNtfObjectCreateDeleteNotificationAllocate()...Done, rc:9 Running saNtfAttributeChangeNotificationAllocate()...Done, rc:9 Running saNtfNotificationSend()...Done, rc:9 Running saNtfNotificationFree()...Done, rc:9 Next: manually STOP both SCs(in UML env. ./opensaf nodestop <1|2>) Then press 'n' and 'Enter' (or 'pkill -USR2 ntftest') to continue. Waiting ... ........n Running saNtfFinalize()...Done, rc:9 Next: manually START both SCs(in UML env. ./opensaf nodestart <1|2>) Then press 'n' and 'Enter' (or 'pkill -USR2 ntftest') to continue. Waiting ... ................... ........n. End test API: saNtfFinalize num of failed notifications: 9 3 FAILED Test saNtfFinalize (expected SA_AIS_OK (1), got SA_AIS_ERR_BAD_HANDLE (9)) ===================================================================================== Test Result: Total: 3 Passed: 0 Failed: 3 Conditions of Submission: ------------------------- *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
