Hi Vijay Some comments: The commit messages for #2550 and #2585 should contain some information about what's fixed. Looks as if the tickets fix the same problem (yes, the tickets contains more info but it is still advisable to give some information about what functionality that is fixed)
For comments on the code see attached diff file Thanks Lennart > -----Original Message----- > From: Vijay Roy [mailto:[email protected]] > Sent: den 25 september 2017 07:57 > To: Lennart Lund <[email protected]> > Cc: [email protected]; Vijay Roy <[email protected]> > Subject: [PATCH 0/1] Review Request for smf: Upgrade failed due to CCB > aborted by imm sync request [#2584] > > Summary: smf: Upgrade failed due to CCB aborted by imm sync request > [#2584] > Review request for Ticket(s): 2584 > Peer Reviewer(s): [email protected] > Pull request to: Any maintainer > Affected branch(es): develop > Development branch: ticket-2584 > Base revision: 61e9fd96d66786cfb6e607a2594fc168c799a95d > Personal repository: git://git.code.sf.net/u/vijayroy/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > NOTE: Patch(es) contain lines longer than 80 characers > > Comments (indicate scope for each "y" above): > --------------------------------------------- > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > revision 9538b111637e3ce6c5a31188fccf00b464dd0484 > Author: Vijay Roy <[email protected]> > Date: Mon, 25 Sep 2017 10:43:17 +0530 > > smf: Upgrade failed due to CCB aborted by imm sync request [#2584] > > > > Complete diffstat: > ------------------ > src/smf/smfd/SmfCampaignWrapup.cc | 50 > +++++++++++++++++++++++++++++++++++++-- > 1 file changed, 48 insertions(+), 2 deletions(-) > > > Testing Commands: > ----------------- > *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** > > 1. Trigger SMF MW upgrade with more then 100000 objects to get hold of > IMM sync. > 2. Set current MW as 5.1 version > 3. Configure SC-1, SC-2, PL-3 > 4. Initiate SMF MW upgrade from 5.1 to 5.2 > 5. During upgrade add the node PL-4. (To Trigger the IMM Sync as listed at > point 1) > > Testing, Expected Results: > -------------------------- > *** PASTE COMMAND OUTPUTS / TEST RESULTS *** > 1. Upgrade Campaign Wrapup should successfully retry during IMM sync > instead of failed. > > Conditions of Submission: > ------------------------- > 1. ACK from reviewer. > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email > etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual.
smf_2584_review1.patch
Description: smf_2584_review1.patch
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
