Summary: dtm: Support multiple OpenSAF internal log streams [#2165]
Review request for Ticket(s): 2165
Peer Reviewer(s): Hans, Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2165
Base revision: 30fdde2868dce841d08e697b39c1bc753346d8a4
Personal repository: git://git.code.sf.net/u/anders-w/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision fea5875204b44b6e9adf1816a247e3ea2a2bd353
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 10 Oct 2017 18:33:13 +0200
base: Use the OpenSAF internal log service for trace [#2165]
Instead of writing trace messages directly to a file, use the OpenSAF internal
log service which is implemented in osaftransportd. As a consequence, the trace
files will now be rotated automatically when they have exceeded the maximum
allowed log file size.
revision a73efc23f247436bda31d61f39a953a4348fa40a
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 10 Oct 2017 18:32:54 +0200
base: Convert logtrace to C++ [#2165]
revision 7ea7e5a9daf5a48fe39831415086ceb72f2f0d22
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 10 Oct 2017 18:32:21 +0200
dtm: Support multiple OpenSAF internal log streams [#2165]
Extend the OpenSAF internal log service so that it supports multiple log streams
in addition to the MDS log. All log streams are received on the same socket and
the stream name is extracted from the MSGID field. Each stream is written to a
separate file based on the name of the stream.
Added Files:
------------
src/base/logtrace.cc
Removed Files:
--------------
src/base/logtrace.c
Complete diffstat:
------------------
src/base/Makefile.am | 2 +-
src/base/logtrace.c | 268 ------------------------
src/base/logtrace.cc | 321 +++++++++++++++++++++++++++++
src/base/logtrace.h | 88 ++++----
src/dtm/transport/log_server.cc | 107 +++++++++-
src/dtm/transport/log_server.h | 36 +++-
src/dtm/transport/log_writer.cc | 16 +-
src/dtm/transport/log_writer.h | 10 +-
src/dtm/transport/osaf-transport.in | 2 +-
src/dtm/transport/tests/log_writer_test.cc | 2 +-
src/dtm/transport/transport_monitor.h | 7 -
src/log/apitest/tet_cfg_destination.c | 8 +-
src/mds/mds_log.cc | 2 +-
13 files changed, 517 insertions(+), 352 deletions(-)
Testing Commands:
-----------------
Start OpenSAF and enable trace for some service(s)
Testing, Expected Results:
--------------------------
Trace should work, and trace files shall be rotated when they
exceed the maximum file size.
Conditions of Submission:
-------------------------
Ack from revier(s), or on 2017-10-17
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
