Hi Hieu,
Please see my minor comment marked with [Quyen]
Thanks,
Quyen
On 10/3/2017 10:50 AM, Hieu Nguyen wrote:
---
python/pyosaf/utils/immom/object.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/pyosaf/utils/immom/object.py
b/python/pyosaf/utils/immom/object.py
index c2924d3..30cd63c 100644
--- a/python/pyosaf/utils/immom/object.py
+++ b/python/pyosaf/utils/immom/object.py
@@ -59,7 +59,7 @@ class ImmObject(object):
self.class_desc[class_name] = \
pyosaf.utils.immom.class_description_get(class_name)
else:
- raise
+ raise Exception("ERROR: class and attributes are None")
[Quyen] I think it's better to raise ValueError instead Exception as
Exception is quite general.
Please also remove the prefix "ERROR: " in the exception description.
BTW: The patch title should describe the summary of the change not the
title of the ticket
self.__dict__["rdn_attribute"] = \
pyosaf.utils.immom.get_rdn_attribute_for_class(class_name)
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
