Summary: smf: refactor smfd folders [#2633]
Review request for Ticket(s): 2633
Peer Reviewer(s): lennart
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2633
Base revision: e7fb995f41a4bfabe3d1e48bda3ba004e2935074
Personal repository: git://git.code.sf.net/u/erafodz/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 410025e485a7f6c98e51ddc504eaf1ad782c5bd8
Author: Rafael Odzakow <rafael.odza...@ericsson.com>
Date: Tue, 17 Oct 2017 14:14:38 +0200
smf: refactor smfd folders [#2633]
Will not compile, just a suggestion.
Added Files:
------------
src/smf/smfd/campaign/SmfCallback.cc
src/smf/smfd/campaign/SmfCallback.h
src/smf/smfd/campaign/SmfCampaign.cc
src/smf/smfd/campaign/SmfCampaign.h
src/smf/smfd/campaign/SmfCampaignInit.cc
src/smf/smfd/campaign/SmfCampaignInit.h
src/smf/smfd/campaign/SmfCampaignThread.cc
src/smf/smfd/campaign/SmfCampaignThread.h
src/smf/smfd/campaign/SmfCampaignWrapup.cc
src/smf/smfd/campaign/SmfCampaignWrapup.h
src/smf/smfd/campaign/SmfCampaignXmlParser.cc
src/smf/smfd/campaign/SmfCampaignXmlParser.h
src/smf/smfd/campaign/SmfCampState.cc
src/smf/smfd/campaign/SmfCampState.h
src/smf/smfd/campaign/SmfRollback.cc
src/smf/smfd/campaign/SmfRollback.h
src/smf/smfd/campaign/SmfTargetTemplate.cc
src/smf/smfd/campaign/SmfTargetTemplate.h
src/smf/smfd/campaign/SmfUpgradeAction.cc
src/smf/smfd/campaign/SmfUpgradeAction.h
src/smf/smfd/campaign/SmfUpgradeCampaign.cc
src/smf/smfd/campaign/SmfUpgradeCampaign.h
src/smf/smfd/campaign/SmfUpgradeMethod.cc
src/smf/smfd/campaign/SmfUpgradeMethod.h
src/smf/smfd/imm/smfd_campaign_oi.cc
src/smf/smfd/imm/SmfExecControlHdl.cc
src/smf/smfd/imm/SmfExecControlHdl.h
src/smf/smfd/imm/SmfImmApplierHdl.cc
src/smf/smfd/imm/SmfImmApplierHdl.h
src/smf/smfd/imm/SmfImmOperation.cc
src/smf/smfd/imm/SmfImmOperation.h
src/smf/smfd/imm/SmfLongDnApplier.cc
src/smf/smfd/imm/SmfLongDnApplier.h
src/smf/smfd/procedure/SmfProcedureThread.cc
src/smf/smfd/procedure/SmfProcedureThread.h
src/smf/smfd/procedure/SmfProcState.cc
src/smf/smfd/procedure/SmfProcState.h
src/smf/smfd/procedure/SmfUpgradeProcedure.cc
src/smf/smfd/procedure/SmfUpgradeProcedure.h
src/smf/smfd/step/SmfStepState.cc
src/smf/smfd/step/SmfStepState.h
src/smf/smfd/step/SmfStepTypes.cc
src/smf/smfd/step/SmfStepTypes.h
src/smf/smfd/step/SmfUpgradeStep.cc
src/smf/smfd/step/SmfUpgradeStep.h
Removed Files:
--------------
src/smf/smfd/SmfCallback.cc
src/smf/smfd/SmfCallback.h
src/smf/smfd/SmfCampaign.cc
src/smf/smfd/SmfCampaign.h
src/smf/smfd/SmfCampaignInit.cc
src/smf/smfd/SmfCampaignInit.h
src/smf/smfd/SmfCampaignThread.cc
src/smf/smfd/SmfCampaignThread.h
src/smf/smfd/SmfCampaignWrapup.cc
src/smf/smfd/SmfCampaignWrapup.h
src/smf/smfd/SmfCampaignXmlParser.cc
src/smf/smfd/SmfCampaignXmlParser.h
src/smf/smfd/SmfCampState.cc
src/smf/smfd/SmfCampState.h
src/smf/smfd/smfd_campaign_oi.cc
src/smf/smfd/SmfExecControlHdl.cc
src/smf/smfd/SmfExecControlHdl.h
src/smf/smfd/SmfImmApplierHdl.cc
src/smf/smfd/SmfImmApplierHdl.h
src/smf/smfd/SmfImmOperation.cc
src/smf/smfd/SmfImmOperation.h
src/smf/smfd/SmfLongDnApplier.cc
src/smf/smfd/SmfLongDnApplier.h
src/smf/smfd/SmfProcedureThread.cc
src/smf/smfd/SmfProcedureThread.h
src/smf/smfd/SmfProcState.cc
src/smf/smfd/SmfProcState.h
src/smf/smfd/SmfRollback.cc
src/smf/smfd/SmfRollback.h
src/smf/smfd/SmfStepState.cc
src/smf/smfd/SmfStepState.h
src/smf/smfd/SmfStepTypes.cc
src/smf/smfd/SmfStepTypes.h
src/smf/smfd/SmfTargetTemplate.cc
src/smf/smfd/SmfTargetTemplate.h
src/smf/smfd/SmfUpgradeAction.cc
src/smf/smfd/SmfUpgradeAction.h
src/smf/smfd/SmfUpgradeCampaign.cc
src/smf/smfd/SmfUpgradeCampaign.h
src/smf/smfd/SmfUpgradeMethod.cc
src/smf/smfd/SmfUpgradeMethod.h
src/smf/smfd/SmfUpgradeProcedure.cc
src/smf/smfd/SmfUpgradeProcedure.h
src/smf/smfd/SmfUpgradeStep.cc
src/smf/smfd/SmfUpgradeStep.h
Complete diffstat:
------------------
src/smf/smfd/SmfCallback.cc | 349 --
src/smf/smfd/SmfCallback.h | 107 -
src/smf/smfd/SmfCampState.cc | 2321 ------------
src/smf/smfd/SmfCampState.h | 455 ---
src/smf/smfd/SmfCampaign.cc | 1034 ------
src/smf/smfd/SmfCampaign.h | 149 -
src/smf/smfd/SmfCampaignInit.cc | 310 --
src/smf/smfd/SmfCampaignInit.h | 154 -
src/smf/smfd/SmfCampaignThread.cc | 966 -----
src/smf/smfd/SmfCampaignThread.h | 208 --
src/smf/smfd/SmfCampaignWrapup.cc | 313 --
src/smf/smfd/SmfCampaignWrapup.h | 137 -
src/smf/smfd/SmfCampaignXmlParser.cc | 3181 -----------------
src/smf/smfd/SmfCampaignXmlParser.h | 590 ----
src/smf/smfd/SmfExecControlHdl.cc | 518 ---
src/smf/smfd/SmfExecControlHdl.h | 119 -
src/smf/smfd/SmfImmApplierHdl.cc | 716 ----
src/smf/smfd/SmfImmApplierHdl.h | 109 -
src/smf/smfd/SmfImmOperation.cc | 1525 --------
src/smf/smfd/SmfImmOperation.h | 644 ----
src/smf/smfd/SmfLongDnApplier.cc | 444 ---
src/smf/smfd/SmfLongDnApplier.h | 81 -
src/smf/smfd/SmfProcState.cc | 1083 ------
src/smf/smfd/SmfProcState.h | 282 --
src/smf/smfd/SmfProcedureThread.cc | 737 ----
src/smf/smfd/SmfProcedureThread.h | 133 -
src/smf/smfd/SmfRollback.cc | 557 ---
src/smf/smfd/SmfRollback.h | 223 --
src/smf/smfd/SmfStepState.cc | 602 ----
src/smf/smfd/SmfStepState.h | 296 --
src/smf/smfd/SmfStepTypes.cc | 2748 --------------
src/smf/smfd/SmfStepTypes.h | 233 --
src/smf/smfd/SmfTargetTemplate.cc | 304 --
src/smf/smfd/SmfTargetTemplate.h | 357 --
src/smf/smfd/SmfUpgradeAction.cc | 589 ---
src/smf/smfd/SmfUpgradeAction.h | 449 ---
src/smf/smfd/SmfUpgradeCampaign.cc | 1275 -------
src/smf/smfd/SmfUpgradeCampaign.h | 508 ---
src/smf/smfd/SmfUpgradeMethod.cc | 371 --
src/smf/smfd/SmfUpgradeMethod.h | 477 ---
src/smf/smfd/SmfUpgradeProcedure.cc | 4713 -------------------------
src/smf/smfd/SmfUpgradeProcedure.h | 867 -----
src/smf/smfd/SmfUpgradeStep.cc | 4009 ---------------------
src/smf/smfd/SmfUpgradeStep.h | 924 -----
src/smf/smfd/campaign/SmfCallback.cc | 349 ++
src/smf/smfd/campaign/SmfCallback.h | 107 +
src/smf/smfd/campaign/SmfCampState.cc | 2321 ++++++++++++
src/smf/smfd/campaign/SmfCampState.h | 455 +++
src/smf/smfd/campaign/SmfCampaign.cc | 1034 ++++++
src/smf/smfd/campaign/SmfCampaign.h | 149 +
src/smf/smfd/campaign/SmfCampaignInit.cc | 310 ++
src/smf/smfd/campaign/SmfCampaignInit.h | 154 +
src/smf/smfd/campaign/SmfCampaignThread.cc | 966 +++++
src/smf/smfd/campaign/SmfCampaignThread.h | 208 ++
src/smf/smfd/campaign/SmfCampaignWrapup.cc | 313 ++
src/smf/smfd/campaign/SmfCampaignWrapup.h | 137 +
src/smf/smfd/campaign/SmfCampaignXmlParser.cc | 3181 +++++++++++++++++
src/smf/smfd/campaign/SmfCampaignXmlParser.h | 590 ++++
src/smf/smfd/campaign/SmfRollback.cc | 557 +++
src/smf/smfd/campaign/SmfRollback.h | 223 ++
src/smf/smfd/campaign/SmfTargetTemplate.cc | 304 ++
src/smf/smfd/campaign/SmfTargetTemplate.h | 357 ++
src/smf/smfd/campaign/SmfUpgradeAction.cc | 589 +++
src/smf/smfd/campaign/SmfUpgradeAction.h | 449 +++
src/smf/smfd/campaign/SmfUpgradeCampaign.cc | 1275 +++++++
src/smf/smfd/campaign/SmfUpgradeCampaign.h | 508 +++
src/smf/smfd/campaign/SmfUpgradeMethod.cc | 371 ++
src/smf/smfd/campaign/SmfUpgradeMethod.h | 477 +++
src/smf/smfd/imm/SmfExecControlHdl.cc | 518 +++
src/smf/smfd/imm/SmfExecControlHdl.h | 119 +
src/smf/smfd/imm/SmfImmApplierHdl.cc | 716 ++++
src/smf/smfd/imm/SmfImmApplierHdl.h | 109 +
src/smf/smfd/imm/SmfImmOperation.cc | 1525 ++++++++
src/smf/smfd/imm/SmfImmOperation.h | 644 ++++
src/smf/smfd/imm/SmfLongDnApplier.cc | 444 +++
src/smf/smfd/imm/SmfLongDnApplier.h | 81 +
src/smf/smfd/imm/smfd_campaign_oi.cc | 1324 +++++++
src/smf/smfd/procedure/SmfProcState.cc | 1083 ++++++
src/smf/smfd/procedure/SmfProcState.h | 282 ++
src/smf/smfd/procedure/SmfProcedureThread.cc | 737 ++++
src/smf/smfd/procedure/SmfProcedureThread.h | 133 +
src/smf/smfd/procedure/SmfUpgradeProcedure.cc | 4713 +++++++++++++++++++++++++
src/smf/smfd/procedure/SmfUpgradeProcedure.h | 867 +++++
src/smf/smfd/smfd_campaign_oi.cc | 1324 -------
src/smf/smfd/step/SmfStepState.cc | 602 ++++
src/smf/smfd/step/SmfStepState.h | 296 ++
src/smf/smfd/step/SmfStepTypes.cc | 2748 ++++++++++++++
src/smf/smfd/step/SmfStepTypes.h | 233 ++
src/smf/smfd/step/SmfUpgradeStep.cc | 4009 +++++++++++++++++++++
src/smf/smfd/step/SmfUpgradeStep.h | 924 +++++
90 files changed, 37491 insertions(+), 37491 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
