Summary: clm: wrapper CLM APIs with try_again handle inside [#2634] Review request for Ticket(s): 2634 Peer Reviewer(s): Hans, Anders Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2634 Base revision: 7261f72a76883008f59a23b66273f213d08ba894 Personal repository: git://git.code.sf.net/u/winhvu/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 2eaa7c94330b7b682cac07732c9c529e828ab733 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 19 Oct 2017 10:41:40 +0700 clm: wrapper CLM APIs with try_again handle inside [#2634] All calls to CLM APIs in clmtest do not handle SA_AIS_ERR_TRY_AGAIN. Running clmtest sometimes get failed because of this miss. Create wrappers which handling try again error code inside. Added Files: ------------ src/clm/apitest/clm_util.c src/clm/apitest/clm_util.h Complete diffstat: ------------------ src/clm/Makefile.am | 4 +- src/clm/apitest/clm_util.c | 385 +++++++++++++++++++++ src/clm/apitest/clm_util.h | 114 ++++++ src/clm/apitest/clmtest.h | 1 + src/clm/apitest/tet_ClmLongRdn.c | 34 +- src/clm/apitest/tet_saClmClusterNodeGet.c | 113 +++--- src/clm/apitest/tet_saClmClusterNodeGetAsync.c | 105 +++--- src/clm/apitest/tet_saClmClusterNotificationFree.c | 19 +- src/clm/apitest/tet_saClmClusterTrack.c | 307 ++++++++-------- src/clm/apitest/tet_saClmClusterTrackStop.c | 29 +- src/clm/apitest/tet_saClmDispatch.c | 29 +- src/clm/apitest/tet_saClmFinalize.c | 17 +- src/clm/apitest/tet_saClmInitialize.c | 76 ++-- src/clm/apitest/tet_saClmResponse.c | 59 ++-- src/clm/apitest/tet_saClmSelectionObjectGet.c | 25 +- 15 files changed, 907 insertions(+), 410 deletions(-) Testing Commands: ----------------- Run `clmtest` Testing, Expected Results: -------------------------- All Test PASS Conditions of Submission: ------------------------- ACK from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel