Summary: ckpt: implement checkpoint state change notifications [#2629]
Review request for Ticket(s): 2629
Peer Reviewer(s): Hoang
Pull request to:
Affected branch(es): develop
Development branch: ticket-2629
Base revision: 308272ff1ce831e6295b744f7f903334ad485052
Personal repository: git://git.code.sf.net/u/trguitar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision a264c06101b5def2ad213a87803c5878b1ff156e
Author: Alex Jones <alex.jo...@genband.com>
Date: Mon, 23 Oct 2017 22:34:25 -0400
ckpt: implement checkpoint state change notifications [#2629]
Fix more submission errors
revision 03473e095ef03455f75859a39c3ade28ecfb10cf
Author: Alex Jones <alex.jo...@genband.com>
Date: Mon, 23 Oct 2017 22:27:21 -0400
ckpt: implement checkpoint state change notifications [#2629]
fix more submission errors
revision a4d7a762ebeac28403c645d25b6de88046728c50
Author: Alex Jones <alex.jo...@genband.com>
Date: Mon, 23 Oct 2017 22:21:16 -0400
ckpt: implement checkpoint state notifications [#2629]
fix submit error
revision 822741377f615dd39e56a18eda4e370fdd6d5dab
Author: Alex Jones <alex.jo...@genband.com>
Date: Mon, 23 Oct 2017 22:20:06 -0400
ckpt: implement checkpoint state change notifications [#2629]
Implementation of Section 6.2.2 of the CKPT-B.02.02 spec.
Complete diffstat:
------------------
src/ais/include/saCkpt.h | 414 ++++++++++++++++++++++++--------------
src/ckpt/Makefile.am | 2 +
src/ckpt/apitest/test_cpa.c | 122 +++++++++++
src/ckpt/apitest/test_cpa_util.c | 190 +++++++++++++++++
src/ckpt/apitest/test_cpsv.h | 13 ++
src/ckpt/apitest/test_cpsv_conf.h | 8 +
src/ckpt/ckptnd/cpnd_cb.h | 3 +
src/ckpt/ckptnd/cpnd_evt.c | 113 +++++++++++
src/ckpt/ckptnd/cpnd_init.c | 57 ++++++
9 files changed, 767 insertions(+), 155 deletions(-)
Testing Commands:
-----------------
1) added new test suite to ckptest
Testing, Expected Results:
--------------------------
1) all should pass
Conditions of Submission:
-------------------------
Oct 30, 2017 or ack from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
