Summary: nid: Derive node ID from TIPC address when not managing TIPC [#2653]
Review request for Ticket(s): 2653
Peer Reviewer(s): Hans, Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2653
Base revision: ee7cb901b8eb023502e3c21180afb78dd15c328b
Personal repository: git://git.code.sf.net/u/anders-w/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts y
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision efa3e715c91405754aac58b3eba58fa6719cb64f
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 25 Oct 2017 14:04:30 +0200
dtm: Always call the configure_tipc script [#2653]
Call the configure_tipc script regardless of whether OpenSAF is configured to
manage TIPC or not. This is needed since the script may need to set up the Node
ID when OpenSAF is not managing TIPC.
revision f7785e02e2457689d57e41ba5aaaa73a6f25b34b
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 25 Oct 2017 14:04:00 +0200
nid: Derive node ID from TIPC address when not managing TIPC [#2653]
If OpenSAF is not configured to manage TIPC, we don't need to require the
presence of /etc/opensaf/slot_id or /var/lib/opensaf/node_id. Instead, we create
the file /var/lib/opensaf/node_id ourselves based on the TIPC address of the
node we are running on. The same translation formula is used (in the opposite
direction) as when OpenSAF is managing TIPC.
Complete diffstat:
------------------
src/dtm/transport/osaf-transport.in | 4 +--
src/nid/configure_tipc.in | 59 ++++++++++++++++++++++++++-----------
2 files changed, 43 insertions(+), 20 deletions(-)
Testing Commands:
-----------------
Configure OpenSAF to not manage TIPC. Start OpenSAF without any of the files
/etc/opensaf/slot_id, /etc/opensaf/subslot_id, /etc/opensaf/chassis_id or
/var/lib/opensaf/node_id
Testing, Expected Results:
--------------------------
OpenSAF shall start successfully and have a Node ID derived from the TIPC
address.
Conditions of Submission:
-------------------------
Ack from reviewer(s)
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
