Hi Alex,
I need one more day to complete my review. Thank you Srinivas From: Alex Jones [mailto:[email protected]] Sent: Wednesday, November 1, 2017 8:07 PM To: srinivas Mangipudy <[email protected]> Cc: [email protected] Subject: Re: [PATCH 0/1] Review Request for msg: fix ERR_UNAVAILABLE code when node leaves and rejoins cluster [#2655] Hi Srinivas, If you have no comments, I will push this tomorrow. Alex On 10/27/2017 10:00 AM, Alex Jones wrote: Summary: msg: fix ERR_UNAVAILABLE code when node leaves and rejoins cluster [#2655] Review request for Ticket(s): 2655 Peer Reviewer(s): Srinivas Pull request to: Affected branch(es): develop Development branch: ticket-2655 Base revision: 2a7a20bafa7f189fca79bd73e6d678c58fda64dd Personal repository: git://git.code.sf.net/u/trguitar/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- revision bbf728124ac8efe8789a6a9758be84fb3300e9e9 Author: Alex Jones HYPERLINK "mailto:[email protected]";<[email protected]> Date: Fri, 27 Oct 2017 09:44:26 -0400 msg: fix ERR_UNAVAILABLE code when node leaves and rejoins cluster [#2655] APIs return SA_AIS_OK after the node leaves then rejoins cluster. Section 3.2 of the MSG B.03.01 spec states that if a node leaves then rejoins the cluster, APIs need to return ERR_UNAVAILABLE for handles that were obtained before the node left the cluster. APIs need to return ERR_UNAVAILABLE for handles that were obtained before the node left the cluster. Added Files: ------------ src/msg/apitest/test_ErrUnavailable.cc Complete diffstat: ------------------ src/msg/Makefile.am | 1 + src/msg/agent/mqa_api.c | 97 +-- src/msg/agent/mqa_db.h | 1 + src/msg/agent/mqa_def.h | 1 + src/msg/agent/mqa_init.c | 26 + src/msg/agent/mqa_mds.c | 14 + src/msg/apitest/test_ErrUnavailable.cc | 1009 ++++++++++++++++++++++++++++++++ src/msg/msgnd/mqnd_evt.c | 42 +- 8 files changed, 1139 insertions(+), 52 deletions(-) Testing Commands: ----------------- run "msgtest" Testing, Expected Results: -------------------------- All tests should pass. Conditions of Submission: ------------------------- Nov 2, 2017, or ack from developer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
