Hi
Just a gentle reminder to review. I would like to push this patch this week if
possible.
Thanks
Gary
-----Original Message-----
From: gary <gary....@dektech.com.au>
Date: Wednesday, 25 October 2017 at 5:52 pm
To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com>, Hans Nordeback
<hans.nordeb...@ericsson.com>, Minh Hon Chau <minh.c...@dektech.com.au>
Cc: <opensaf-devel@lists.sourceforge.net>, gary <gary....@dektech.com.au>
Subject: [PATCH 0/1] Review Request for amfnd: do not refresh opensaf
components [#2627]
Summary: amfnd: do not refresh opensaf components [#2627]
Review request for Ticket(s): 2627
Peer Reviewer(s): AMF devs
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): all
Development branch: ticket-2627
Base revision: ee7cb901b8eb023502e3c21180afb78dd15c328b
Personal repository: git://git.code.sf.net/u/userid-2226215/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision e4979b496fa52608bb607cd6f08634df98b23317
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 25 Oct 2017 14:47:49 +1100
amfnd: do not refresh opensaf components [#2627]
If an OpenSAF component requires reload after an upgrade,
then AMF should also be upgraded, requiring a node
reboot. Thus there is no need to refresh component
config.
The patch fixes a problem where OpenSAF has been upgraded
and is about to be rebooted. Before the reboot occurs,
IMMND aborts due to message loss, and AMFND is trying to
reload IMMND's configuration. Since IMMND is down, AMFND
is stuck in saImmOmInitialize(), before eventually being killed
by the AMF watchdog.
Complete diffstat:
------------------
src/amf/amfnd/compdb.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
