Summary: dtm: Support pretty-printing OpenSAF logs using the osaflog command [#2709] Review request for Ticket(s): 2709 Peer Reviewer(s): Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2709 Base revision: 6bc487855d75481724905f729e3782bf8b153a2b Personal repository: git://git.code.sf.net/u/anders-w/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision 640a7f6ce590d2bef128019d6cec887616595e3d Author: Anders Widell <[email protected]> Date: Fri, 1 Dec 2017 10:47:14 +0100 dtm: Support pretty-printing OpenSAF logs using the osaflog command [#2709] Add support to the osaflog command for parsing and pretty-printing the OpenSAF log messages. Initially, we only support simple pretty-printing by removing information which is not frequently needed when reading the logs. In future ticket(s), we can also add support for filtering log messages. The following example command will print the MDS log: osaflog mds.log Complete diffstat: ------------------ src/dtm/common/osaflog_protocol.h | 20 ++++ src/dtm/tools/osaflog.cc | 220 ++++++++++++++++++++++++++++++-------- src/dtm/transport/log_server.cc | 17 +-- src/dtm/transport/log_server.h | 2 - 4 files changed, 196 insertions(+), 63 deletions(-) Testing Commands: ----------------- Run e.g. the command "osaflog mds.log" Testing, Expected Results: -------------------------- The MDS log shall be printed in a concise format. Conditions of Submission: ------------------------- Ack from reviewer(s), or on 2017-12-08 if no comments have been received. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
