ACK
On fre, 2017-12-01 at 16:13 +0100, Lennart Lund wrote: > Summary: smf: Add MDS logging to smfd and smfnd [#2722] > Review request for Ticket(s): 2722 > Peer Reviewer(s): [email protected] > Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > Affected branch(es): develop > Development branch: ticket-2722 > Base revision: d40172a1afb2f95afdb6b6b5cf4804d559ac6c50 > Personal repository: git://git.code.sf.net/u/elunlen/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > revision 69653a7b4c6fe9863d3b04d938f20eccc93092aa > Author: Lennart Lund <[email protected]> > Date: Fri, 1 Dec 2017 15:58:00 +0100 > > smf: Add MDS logging to smfd and smfnd [#2722] > > Add syslogs to smfd and smfnd to log MDS handling so that > initializing, role > change MDS events etc. All of these logs will be tagged with 'MDS ' > to make > it possible to grep. There will be a number of new logs added to > syslog but > all of these logs will only be written at special occasions like > start up, > service down / up etc. > > > > Complete diffstat: > ------------------ > src/smf/smfd/smfd_amf.cc | 2 ++ > src/smf/smfd/smfd_main.cc | 5 ++++- > src/smf/smfd/smfd_mds.c | 35 +++++++++++++++++++++++++++-------- > src/smf/smfnd/smfnd_main.c | 1 + > src/smf/smfnd/smfnd_mds.c | 18 ++++++++++++++---- > 5 files changed, 48 insertions(+), 13 deletions(-) > > > Testing Commands: > ----------------- > *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** > > > Testing, Expected Results: > -------------------------- > *** PASTE COMMAND OUTPUTS / TEST RESULTS *** > > > Conditions of Submission: > ------------------------- > *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any > checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank > entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and > push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your > commits. > > ___ You have incorrectly put/left internal data in your > comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build > tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be > removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there > is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be > pulled. > > ___ You have too many commits attached to an e-mail; resend as > threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear > indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial > review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, > user.email etc) > > ___ Your computer have a badly configured date and time; confusing > the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any > results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch > series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
