Hi Lennart, I agree. Since there is already a ticket 1531 to handle this scenario in a separate thread, I will close this issue as duplicate.
Thank you Srinivas -----Original Message----- From: Lennart Lund [mailto:[email protected]] Sent: Wednesday, December 13, 2017 4:30 PM To: Srinivas <[email protected]>; Vu Minh Nguyen <[email protected]>; Canh Van Truong <[email protected]> Cc: [email protected] Subject: RE: [PATCH 0/1] Review Request for log: Added retry logic for RT object creation call fails due to timeout error [#2711] Hi Srinivas Is this really a defect? The API for creating a new log stream is synchronous and if the log server fails to create the stream, in this case because the stream object could not be created, it will report the fail back to the agent and the agent will reply with TRY AGAIN to the client. The basic thinking around recoverable problems is to let the client decide whether it is relevant to try again or not. Thanks Lennart > -----Original Message----- > From: Srinivas [mailto:[email protected]] > Sent: den 4 december 2017 10:34 > To: Lennart Lund <[email protected]>; Vu Minh Nguyen > <[email protected]> > Cc: [email protected]; Srinivas > <[email protected]> > Subject: [PATCH 0/1] Review Request for log: Added retry logic for RT > object creation call fails due to timeout error [#2711] > > Summary: log: Added retry logic for RT object creation call fails due > to timeout error [#2711] Review request for Ticket(s): 2711 Peer > Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE > *** > Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > Affected branch(es): develop Development branch: ticket-2711 Base > revision: d40172a1afb2f95afdb6b6b5cf4804d559ac6c50 > Personal repository: git://git.code.sf.net/u/sri-mangipudy/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services n > OpenSAF services y > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > Added retry logic for RT object creation call fails due to timeout > error > > revision 18ade0da54361ca3655daac7542c87eac56dadd7 > Author: Srinivas <[email protected]> > Date: Mon, 4 Dec 2017 14:14:07 +0530 > > log: Added retry logic for RT object creation call fails due to > timeout error [#2711] > > > > Complete diffstat: > ------------------ > src/log/logd/lgs_stream.cc | 44 +++++++++++++++++++++++++++++++----- > -------- > 1 file changed, 31 insertions(+), 13 deletions(-) > > > Testing Commands: > ----------------- > 1. Keep only SC-1 up. > 2. Trigger to suspend immnd(e.i, use SIGSTOP) in the time log client > processing saLogStreamOpen_2() to create runtime stream. > 3. Continue immnd(e.i, SIGCONT) after catching > "saImmOiRtObjectCreate_2 returned 5" in syslog. > > Testing, Expected Results: > -------------------------- > *** PASTE COMMAND OUTPUTS / TEST RESULTS *** > > > Conditions of Submission: > ------------------------- > *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any > checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, > user.email > etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
