Summary: ntf: fix [fix ntfd remove client in standby node while not finalize in active node [#2705] Review request for Ticket(s): 2705 Peer Reviewer(s): Minh Pull request to: Minh Affected branch(es): develop, release Development branch: ticket-2705 Base revision: 52724f300293bc26ea33ac63367e826a9e3b054a Personal repository: git://git.code.sf.net/u/canht32/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 0e18a731840dfa2240ccdafc23f0ccbfdc9e81f7 Author: Canh Van Truong <[email protected]> Date: Mon, 18 Dec 2017 11:41:12 +0700 ntf: fix [fix ntfd remove client in standby node while not finalize in active node [#2705] The issue happen because the clients are removed in both active and standby node when getting NCSMDS_DOWN event. In standby node, ntfd get NCSMDS_DOWN event is slower than next initialize request. This cause the ntfd will removed all client from data base including new client of next initialze. Any action relate to this client will fail. Before putting NCSMDS_DOWN event down in mbx, the patch set clients down flag. And standby ntfd only remove the clients belong of mds_dest down and have flag down Complete diffstat: ------------------ src/ntf/ntfd/NtfAdmin.cc | 62 +++++++++++++++++++++++++++++++++++++++++++++++ src/ntf/ntfd/NtfAdmin.h | 6 +++++ src/ntf/ntfd/NtfClient.cc | 11 ++++++--- src/ntf/ntfd/NtfClient.h | 6 +++++ src/ntf/ntfd/ntfs_com.h | 2 ++ src/ntf/ntfd/ntfs_evt.c | 8 ++++-- src/ntf/ntfd/ntfs_mds.c | 11 ++++++++- 7 files changed, 100 insertions(+), 6 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: ------------------------- Ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
